Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default linux port got changed again... #882

Closed
skliper opened this issue Sep 11, 2020 · 0 comments · Fixed by #883 or #891
Closed

Default linux port got changed again... #882

skliper opened this issue Sep 11, 2020 · 0 comments · Fixed by #883 or #891
Labels
bug
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Sep 11, 2020

Describe the bug
Processor ID was set to 10, ci uses it to deconflict ports. Broke toolchain.

To Reproduce
Normal run, reports CI is listening on 1243 (should be 1234)

Expected behavior
Use historical port by default.

Code snips

cFE/cmake/sample_defs/targets.cmake

Line 103 in db82929

SET(cpu1_PROCESSORID 10)

System observed on:

  • Hardware: cFS Dev server
  • OS: Ubuntu 18.04
  • Versions: Bundle main

Additional context
Broke in #776. Really should fix nasa/cFS#56 (positive check in CI of proper execution and exit), and this would have been caught.

Reporter Info
Jacob Hageman - NASA/GSFC
skliper added a commit to skliper/cFE that referenced this issue Sep 11, 2020
@skliper
Fix nasa#882, Returned processor ID to default to unbreak toolchain
792ef77
@skliper skliper mentioned this issue Sep 11, 2020
Merged
skliper added a commit to skliper/cFE that referenced this issue Sep 11, 2020
@skliper
Fix nasa#882, Returned processor ID to default to unbreak toolchain
56618e8
@skliper skliper added the bug label Sep 11, 2020
yammajamma added a commit that referenced this issue Sep 17, 2020
@yammajamma
Merge pull request #883 from skliper/fix882-processorid-default
c3ab053 
Fix #882, Returned processor ID to default to unbreak toolchain
@yammajamma yammajamma mentioned this issue Sep 17, 2020
Merged
@astrogeco astrogeco added this to the 7.0.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco