Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub CFE to use correct type for OSAL IDs #858

Closed
jphickey opened this issue Sep 2, 2020 · 0 comments · Fixed by #868 or #876
Closed

Scrub CFE to use correct type for OSAL IDs #858

jphickey opened this issue Sep 2, 2020 · 0 comments · Fixed by #868 or #876
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented Sep 2, 2020

Is your feature request related to a problem? Please describe.
nasa/osal#568 introduces a proper typedef for OSAL IDs: osal_id_t

Describe the solution you'd like
The CFE needs to be scrubbed to use this typedef whenever storing an OSAL ID, rather than uint32

Describe alternatives you've considered
Keep using uint32 as-is, but that defeats the purpose of having a typedef.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Sep 8, 2020
jphickey added a commit to jphickey/cFE that referenced this issue Sep 8, 2020
@jphickey
Fix nasa#858, update CFE to use OSAL ID type
4bad070 
Use the OSAL-supplied typedef `osal_id_t` to store OSAL IDs,
along with OSAL-supplied conversion/cast routines when interfacing
this value with other modules.
jphickey added a commit to jphickey/cFE that referenced this issue Sep 8, 2020
@jphickey
Fix nasa#858, update CFE to use OSAL ID type
a492be7 
Use the OSAL-supplied typedef `osal_id_t` to store OSAL IDs,
along with OSAL-supplied conversion/cast routines when interfacing
this value with other modules.
@jphickey jphickey mentioned this issue Sep 8, 2020
Merged
@jphickey jphickey linked a pull request Sep 9, 2020 that will close this issue
Fix #858, use osal id typedef #868
Merged
@skliper skliper added this to the 7.0.0 milestone Sep 9, 2020
yammajamma added a commit that referenced this issue Sep 10, 2020
@yammajamma
Merge pull request #868 from jphickey/fix-858-osal-id-type
bc48dc0 
Fix #858, use osal id typedef
@yammajamma yammajamma mentioned this issue Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #858, use osal id typedef jphickey/cFE
Integration Candidate: 2020-09-09 nasa/cFE
2 participants
@jphickey @skliper