Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document configs to indicate that MAX string sizes do not include null-terminator #735

Closed
CDKnightNASA opened this issue Jun 5, 2020 · 0 comments · Fixed by #1168 or #1171
Closed

document configs to indicate that MAX string sizes do not include null-terminator #735

CDKnightNASA opened this issue Jun 5, 2020 · 0 comments · Fixed by #1168 or #1171
Assignees
@zanzaben
Labels
docs This change only affects documentation. good first issue Good for newcomers help wanted
Milestone
Caelum

Comments

@CDKnightNASA
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There is a laundry list of string size definitions in sample_mission_cfg.h, cpu1_platform_cfg.h, and default_osconfig.cmake that should be documented as to whether the setting includes a byte for a null-terminator (so say CFE_MISSION_TBL_MAX_NAME_LENGTH is defined as 16, does that mean I must limit my table name to 15 characters plus the null-terminator?)

This is related to #730 .

Requester Info
[email protected]
@CDKnightNASA CDKnightNASA added help wanted good first issue Good for newcomers docs This change only affects documentation. labels Jun 5, 2020
@CDKnightNASA CDKnightNASA mentioned this issue Jun 5, 2020
Closed
tcannon686 added a commit to tcannon686/cFE that referenced this issue Aug 2, 2020
@tcannon686
fix issue nasa#735
3aa5165 
This commit clarifies null termination in some of the settings in
cmake/sample_defs. There are also a couple small changes to detect the
case where the string is exactly as long as the maximum, so would not
have a null terminator.
@skliper skliper added this to the 7.0.0 milestone Jan 11, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue Feb 12, 2021
@zanzaben
Fix nasa#735, comment if null terminated or not.
01ce577
zanzaben added a commit to zanzaben/cFE that referenced this issue Feb 16, 2021
@zanzaben
Fix nasa#735, comment if null terminated or not.
ec65900
@zanzaben zanzaben mentioned this issue Feb 16, 2021
Merged
zanzaben added a commit to zanzaben/cFE that referenced this issue Feb 17, 2021
@zanzaben
Fix nasa#735, comment if null terminated or not.
81e907f
astrogeco added a commit that referenced this issue Feb 24, 2021
@astrogeco
Merge pull request #1168 from zanzaben/fix735_document_null_terminators
ab21c87 
Fix #735, add comment if null terminated or not.
@astrogeco astrogeco mentioned this issue Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
docs This change only affects documentation. good first issue Good for newcomers help wanted
Projects
None yet
Milestone
Caelum
3 participants
@zanzaben @CDKnightNASA @skliper