Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to "CCSDS" structures outside of CFE SB. #719

Closed
jphickey opened this issue May 27, 2020 · 3 comments · Fixed by #725 or #729
Closed

Remove references to "CCSDS" structures outside of CFE SB. #719

jphickey opened this issue May 27, 2020 · 3 comments · Fixed by #725 or #729
Assignees
@jphickey
Labels
bug
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

jphickey commented May 27, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
As a prerequisite to #554, all modules other than SB should NOT refer to the "CCSDS" data types and macros.

Describe the solution you'd like
Remove references to the ccsds.h header file along with any direct references to types defined in this file. Use the types or abstractions defined in cfe_sb.h instead.

Additional context
Mostly an issue for the "Send HK" commands that accept a CCSDS_CommandPacket_t structure.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@skliper
Copy link
Contributor

skliper commented May 28, 2020

@jphickey could you prioritize this one?

jphickey added a commit to jphickey/cFE that referenced this issue May 28, 2020
@jphickey
Fix nasa#719, remove refs to ccsds data structures
755851f 
Replace all direct references to data types defined in ccsds.h
with the abstract type defined in cfe_sb.h
@jphickey jphickey mentioned this issue May 28, 2020
Merged
@jphickey
Copy link
Contributor Author

@jphickey could you prioritize this one?

Submitted PR, will submit similar issues/PRs for apps too.

@jphickey
Copy link
Contributor Author

FYI: nasa/ci_lab#49, nasa/to_lab#42, nasa/sample_app#69 are the related PRs for the apps.

@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 28, 2020
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jun 1, 2020
astrogeco added a commit that referenced this issue Jun 2, 2020
@astrogeco
Merge pull request #725 from jphickey/fix-719-remove-ccsds-refs
0cad269 
Fix #719, remove refs to ccsds data structures
@astrogeco astrogeco mentioned this issue Jun 9, 2020
Merged
@astrogeco astrogeco added the bug label Sep 15, 2020
@gustavodinis gustavodinis mentioned this issue Oct 21, 2020
Open
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Bootes
3 participants
@jphickey @skliper @astrogeco