Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate secondary header access API's from SB #711

Closed
skliper opened this issue May 19, 2020 · 0 comments · Fixed by #726 or #833
Closed

Separate secondary header access API's from SB #711

skliper opened this issue May 19, 2020 · 0 comments · Fixed by #726 or #833
Labels
enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented May 19, 2020

Is your feature request related to a problem? Please describe.
Need to support #554
Software bus logic doesn't care about message format, just use message access APIs like all the other services.

Describe the solution you'd like
MSG module and header file for all the message getter/setters. Deprecation of the SB API's. Code separation to support source selection/mission configuration.

Describe alternatives you've considered
None

Additional context
#554

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper mentioned this issue May 19, 2020
Closed
@skliper skliper changed the title Separate message access API's from SB Separate secondary header access API's from SB May 28, 2020
skliper added a commit to skliper/cFE that referenced this issue May 28, 2020
@skliper
Fix nasa#711, Seperate sechdr access functions
21de6b0 
Also enables source selection and out-of-tree
mission defined overrides
skliper added a commit to skliper/cFE that referenced this issue May 28, 2020
@skliper
Fix nasa#711, Seperate sechdr access functions
888666f 
Also enables source selection and out-of-tree
mission defined overrides
@skliper skliper mentioned this issue May 28, 2020
Merged
skliper added a commit to skliper/cFE that referenced this issue Jun 2, 2020
@skliper
Fix nasa#711, Relative paths, typos, better dependency
b5c8be6 
MISSION_CORE_MODULES now set early (mission_build.cmake) allowing
override or append in user config.

Fixed typos in cfe_msg.h, and moved local to module until
APIs are cleaned up (still available as include)

Moving towards a module file structure
skliper added a commit to skliper/cFE that referenced this issue Jun 2, 2020
@skliper
Fix nasa#711, Relative paths, typos, better dependency
844f8af 
MISSION_CORE_MODULES now set early (mission_build.cmake) allowing
override or append in user config.

Fixed typos in cfe_msg.h, and moved local to module until
APIs are cleaned up (still available as include)

Moving towards a module file structure
skliper added a commit to skliper/cFE that referenced this issue Jun 2, 2020
@skliper
Fix nasa#711, Move core modules to arch_build
67dbcc4
@skliper skliper mentioned this issue Jun 6, 2020
Closed
skliper added a commit to skliper/cFE that referenced this issue Jun 9, 2020
@skliper
Fix nasa#711, Version 1 refactored
644242c 
Compiles, runs, and tlm/cmd work
Unit testing still broken
Need to unit test new functions
Didn't convert to built in path search/include method
skliper added a commit to skliper/cFE that referenced this issue Jun 9, 2020
@skliper
Fix nasa#711, Squashed cppcheck issues
57aeb8f
skliper added a commit to skliper/cFE that referenced this issue Jun 10, 2020
@skliper
Fix nasa#711, Minor cleanup
47aa6a7 
Moved CFE_MSG_InitDefaultHdr to cfe_msg_priv.h
Added missing TODO in ccsds.h
skliper added a commit to skliper/cFE that referenced this issue Jun 10, 2020
@skliper
Fix nasa#711, Applied style
84569de
skliper added a commit to skliper/cFE that referenced this issue Jun 10, 2020
@skliper
Fix nasa#711, Added extended functions and minor cleanup
a08b68c
skliper added a commit to skliper/cFE that referenced this issue Jun 10, 2020
@skliper
Fix nasa#711, Minor bug fixes
60a8cdd
skliper added a commit to skliper/cFE that referenced this issue Jun 12, 2020
@skliper
Fix nasa#711, Seperate sechdr access functions
5366e0c 
Also enables source selection and out-of-tree
mission defined overrides
skliper added a commit to skliper/cFE that referenced this issue Jun 12, 2020
@skliper
Fix nasa#711, Relative paths, typos, better dependency
5ef0f01 
MISSION_CORE_MODULES now set early (mission_build.cmake) allowing
override or append in user config.

Fixed typos in cfe_msg.h, and moved local to module until
APIs are cleaned up (still available as include)

Moving towards a module file structure
skliper added a commit to skliper/cFE that referenced this issue Jun 12, 2020
@skliper
Fix nasa#711, Move core modules to arch_build
af8c144
skliper added a commit to skliper/cFE that referenced this issue Jun 12, 2020
@skliper
Fix nasa#711, Version 1 refactored
a493c7b 
Compiles, runs, and tlm/cmd work
Unit testing still broken
Need to unit test new functions
Didn't convert to built in path search/include method
skliper added a commit to skliper/cFE that referenced this issue Jun 12, 2020
@skliper
Fix nasa#711, Squashed cppcheck issues
2448e02
skliper added a commit to skliper/cFE that referenced this issue Jun 12, 2020
@skliper
Fix nasa#711, Minor cleanup
0055df1 
Moved CFE_MSG_InitDefaultHdr to cfe_msg_priv.h
Added missing TODO in ccsds.h
skliper added a commit to skliper/cFE that referenced this issue Jun 12, 2020
@skliper
Fix nasa#711, Applied style
c2b5cef
skliper added a commit to skliper/cFE that referenced this issue Jun 12, 2020
@skliper
Fix nasa#711, Added extended functions and minor cleanup
aa0ad2b
skliper added a commit to skliper/cFE that referenced this issue Jun 12, 2020
@skliper
Fix nasa#711, Minor bug fixes
129164b
skliper added a commit to skliper/cFE that referenced this issue Jun 12, 2020
@skliper
Fix nasa#711, Minor bug fix
b22eb5b
@jphickey jphickey mentioned this issue Jun 12, 2020
Closed
skliper added a commit to skliper/cFE that referenced this issue Jul 2, 2020
@skliper
Fix nasa#711, Seperate sechdr access functions
77215ea 
Also enables source selection and out-of-tree
mission defined overrides
skliper added a commit to skliper/cFE that referenced this issue Jul 2, 2020
@skliper
Fix nasa#711, Relative paths, typos, better dependency
a0f3e15 
MISSION_CORE_MODULES now set early (mission_build.cmake) allowing
override or append in user config.

Fixed typos in cfe_msg.h, and moved local to module until
APIs are cleaned up (still available as include)

Moving towards a module file structure
skliper added a commit to skliper/cFE that referenced this issue Jul 2, 2020
@skliper
Fix nasa#711, Move core modules to arch_build
af034c4
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Added interface and more work on UT
3af2bb5
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Adopted updated cmake model
2f79f37
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Clean headers and no longer deprecating
49851ec
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Clean TODOs and no longer deprecating
9627ce0
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Update to use new APIs
2040c08
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Clean unit test build recipe
ab26c7b
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Update unit tests for new routines
c2d4ea0
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Fix bugs found unit testing
91d877e
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Clean UT and squash bugs
35fe11a
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Update msg and ut recipe, raw byte checksum access
fb0d4cc
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Add MsgId V2 and extended header source selection
778943d
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Update defines (and location), error return from MSG_Init
3ff06f3
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Add unit tests and improve error logic
b5467c1
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Add msgid max val and update fcncode check
4e15ff2
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Applied style
16f742c
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Added missing include for msgid limit check
c020a90
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Unit test and alignment updates
84c1fc7 
Software bus cmd/tlm types now aligned via union
Removed send with invalid msgid tests (can't set invalid msgid)
SB unit tests now pass with VER_2 defined
Backed out 64 bit alignment of messages
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Remove unreachable code and typos
3c97b9c
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Add msg module unit tests
648b9fa
skliper added a commit to skliper/cFE that referenced this issue Aug 7, 2020
@skliper
Fix nasa#711, Clean TODOs and use old time logic by default
a782f4f
skliper added a commit to skliper/cFE that referenced this issue Aug 11, 2020
@skliper
Fix nasa#711, cppcheck modules and fix syntax error
ff5f19b
skliper added a commit to skliper/cFE that referenced this issue Aug 12, 2020
@skliper
Fix nasa#711, Add msg API header to cfe.h
cd3742f
skliper added a commit to skliper/cFE that referenced this issue Aug 14, 2020
@skliper
Fix nasa#711, Add message header module
d3a073e 
Implements message header module such that users
can customize or extend as needed.
 - Separates code for easier selection
 - Implements consistent getter/setter APIs
 - Fix nasa#736/nasa#781: MsgId logic no longer overrides bits in init
 - Fix nasa#529: Get size supports max size
 - Adds single big endian time implementation, but not selected
 - Adds msg module to module list
 - Adds msg module to cppcheck
skliper added a commit to skliper/cFE that referenced this issue Aug 14, 2020
@skliper
Fix nasa#711, Update SB/CCSDS FSW for msg module
8563679 
- Fix nasa#733: Validate checksum description update
- Fix nasa#597: Remove local endian SID macros
- Updates SB to use msg module
- General cleanup
skliper added a commit to skliper/cFE that referenced this issue Aug 14, 2020
@skliper
Fix nasa#711, SB unit test updates for msg module
97682b8 
- Removes dependencies on old macros
- Simplifies unit tests
- Treats msg module as internal code for now (temporary)
skliper added a commit to skliper/cFE that referenced this issue Aug 14, 2020
@skliper
Fix nasa#711, Add msg module unit test
164c75e
yammajamma added a commit that referenced this issue Aug 20, 2020
@yammajamma
Merge pull request #726 from skliper/fix711-msg-access
fc0c586 
Fix #711, Separate secondary header access functions
@yammajamma yammajamma mentioned this issue Aug 24, 2020
Merged
@astrogeco astrogeco added this to the 7.0.0 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco