Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE core build should link with the OSAL BSP library #532

Closed
jphickey opened this issue Feb 26, 2020 · 1 comment · Fixed by #533
Closed

CFE core build should link with the OSAL BSP library #532

jphickey opened this issue Feb 26, 2020 · 1 comment · Fixed by #533
Labels

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The CFE PSP has historically duplicated some logic that was also in the OSAL BSP. In an effort to consolidate this and have only one basic BSP implementation, the CFE PSP should be an extension of the OSAL BSP rather than duplicating the logic.

Describe the solution you'd like
The first step to accomplish this is to have the CFE final link also include the osal_bsp library in the final link.

Additional context
Including osal_bsp should not affect existing builds as long as it is included after the PSP, so the linker will not pull in duplicate symbols. It should be effectively a no-op/ignored in the current build but enables a future transition to using the osal-provided BSP for startup.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

jphickey added a commit to jphickey/cFE that referenced this issue Feb 26, 2020
Enables future transition to using the OSAL BSP rather than
duplicating startup logic in the CFE PSP.
astrogeco added a commit that referenced this issue Apr 1, 2020
@jphickey
Copy link
Contributor Author

jphickey commented Apr 2, 2020

Withdrawing this -- my cross-platform testing showed it didn't work as originally planned. Replaced by #581 instead, which seems to work on all platforms so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants