Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES Performance debug messages have incorrect parameter #315

Closed
skliper opened this issue Sep 30, 2019 · 2 comments · Fixed by #461
Closed

ES Performance debug messages have incorrect parameter #315

skliper opened this issue Sep 30, 2019 · 2 comments · Fixed by #461
Labels
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

The second parameter in the following two debug event messages are incorrect:

        CFE_EVS_SendEvent(CFE_ES_PERF_FILTMSKCMD_EID, CFE_EVS_DEBUG,
                    "Set Performance Filter Mask Cmd rcvd, num %d, val 0x%x",
        (int)cmd->FilterMaskNum,(unsigned int)cmd->FilterMaskNum);


        CFE_EVS_SendEvent(CFE_ES_PERF_TRIGMSKCMD_EID, CFE_EVS_DEBUG,
                  "Set Performance Trigger Mask Cmd rcvd,num %d, val 0x%x",
               (int)cmd->TriggerMaskNum,(int)cmd->TriggerMaskNum);

In both cases "Num" should be removed from the second parameter variable. The casting should also be examined.

@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 284. Created by dcmccom3 on 2019-04-29T15:43:15, last modified: 2019-05-23T16:43:54

@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by dcmccom3 on 2019-04-30 07:16:07:

It's not simply removing "Num" to solve the problem. It requires indexing the appropriate variable which will be obvious in the code.

@skliper skliper removed their assignment Sep 30, 2019
dmknutsen added a commit to dmknutsen/cFE that referenced this issue Jan 8, 2020
dmknutsen added a commit to dmknutsen/cFE that referenced this issue Jan 8, 2020
@astrogeco astrogeco linked a pull request Feb 11, 2020 that will close this issue
dmknutsen added a commit to dmknutsen/cFE that referenced this issue Feb 12, 2020
astrogeco added a commit that referenced this issue Feb 25, 2020
Fix #315, ES Performance debug messages
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant