Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static analysis issues JSC 2.1 #2552

Closed
chillfig opened this issue Apr 24, 2024 · 0 comments · Fixed by #2568
Closed

Static analysis issues JSC 2.1 #2552

chillfig opened this issue Apr 24, 2024 · 0 comments · Fixed by #2568
Assignees
Labels

Comments

@chillfig
Copy link
Contributor

chillfig commented Apr 24, 2024

Describe the bug
Handful of static analysis issues. This report records the findings from the static analysis to facilitate their tracking.

Source Folder Source Filename Source Line Source Object Destination Folder Destination Filename Destination Line Destination Object Disposition
Unchecked Return Value of a Function                
\cfe\modules\evs\fsw\src cfe_evs_utils.c 548 snprintf         Will Fix. cFE PR #2566
Use of sizeof in pointer                
\cfe\modules\evs\fsw\src cfe_evs.c 119 Spec \cfe\modules\evs\fsw\src cfe_evs.c 149 sizeof Will Not Fix. sizeof is not applied to Spec directly; instead, Spec is used as a format string in vsnprintf within EVS_GenerateEventTelemetry, which handles the string length appropriately based on the format specified and the variable arguments received.
\cfe\modules\evs\fsw\src cfe_evs.c 169 Spec \cfe\modules\evs\fsw\src cfe_evs.c 199 sizeof Will Not Fix. sizeof is not applied to Spec directly; instead, Spec is used as a format string in vsnprintf within EVS_GenerateEventTelemetry, which handles the string length appropriately based on the format specified and the variable arguments received.
\cfe\modules\evs\fsw\src cfe_evs.c 218 Spec \cfe\modules\evs\fsw\src cfe_evs.c 244 sizeof Will Not Fix. sizeof is not applied to Spec directly; instead, Spec is used as a format string in vsnprintf within EVS_GenerateEventTelemetry, which handles the string length appropriately based on the format specified and the variable arguments received.
Buffer Improper Index Access                
\osal\src\os\portable os-impl-posix-io.c 195 buffer \tools\ctf\external\sample_cfs_workspace\cfe\modules\tbl\fsw\src cfe_tbl_internal.c 1255 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \cfe\modules\fs\fsw\src cfe_fs_api.c 359 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \cfe\modules\tbl\fsw\src cfe_tbl_internal.c 1213 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \tools\ctf\external\sample_cfs_workspace\cfe\modules\fs\fsw\src cfe_fs_api.c 369 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \tools\ctf\external\sample_cfs_workspace\cfe\modules\tbl\fsw\src cfe_tbl_internal.c 1256 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \cfe\modules\fs\fsw\src cfe_fs_api.c 360 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \cfe\modules\tbl\fsw\src cfe_tbl_internal.c 1214 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \tools\ctf\external\sample_cfs_workspace\cfe\modules\fs\fsw\src cfe_fs_api.c 370 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \tools\ctf\external\sample_cfs_workspace\cfe\modules\tbl\fsw\src cfe_tbl_internal.c 1257 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \tools\ctf\external\sample_cfs_workspace\cfe\modules\fs\fsw\src cfe_fs_api.c 371 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \cfe\modules\fs\fsw\src cfe_fs_api.c 357 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \cfe\modules\tbl\fsw\src cfe_tbl_internal.c 1211 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \tools\ctf\external\sample_cfs_workspace\cfe\modules\fs\fsw\src cfe_fs_api.c 372 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \tools\ctf\external\sample_cfs_workspace\cfe\modules\tbl\fsw\src cfe_tbl_internal.c 1254 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \cfe\modules\fs\fsw\src cfe_fs_api.c 358 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.
\osal\src\os\portable os-impl-posix-io.c 195 buffer \cfe\modules\tbl\fsw\src cfe_tbl_internal.c 1212 OutPtr Will Not Fix. Safe access to InPtr[0-3] and OutPtr[0-3] as both manipulate bytes within 4-byte integers.

To Reproduce
N/A. These issues were communicated by JSC.

Expected behavior
Need to resolve these. Should resolve and/or disposition the higher ranked ones at minimum.

Code snips
N/A

System observed on:
N/A

Additional context
N/A

Reporter Info
Imported from JSC 2.1 static analysis

@chillfig chillfig added the bug label Apr 24, 2024
@chillfig chillfig self-assigned this Apr 24, 2024
chillfig pushed a commit to chillfig/cFE that referenced this issue Jun 13, 2024
chillfig pushed a commit to chillfig/cFE that referenced this issue Jun 14, 2024
chillfig pushed a commit to chillfig/cFE that referenced this issue Jun 14, 2024
chillfig pushed a commit to chillfig/cFE that referenced this issue Jun 17, 2024
dzbaker added a commit that referenced this issue Jul 1, 2024
Fix #2552, Adds JSC 2.1 Static Analysis comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant