Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EDS build hooks #2507

Closed
jphickey opened this issue Jan 31, 2024 · 0 comments · Fixed by #2511
Closed

Add EDS build hooks #2507

jphickey opened this issue Jan 31, 2024 · 0 comments · Fixed by #2511
Assignees
@jphickey
Labels
enhancement

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As part of adding EDS functionality into CFE/CFS - the overall feature set is controlled by a boolean configuration option. This in turn enables other parts of the scripts that can be gated on that option being true.

Describe the solution you'd like
Add the CFE_EDS_ENABLED_BUILD option at the top level, along with other link library and subdirectory tie-ins that can be enabled only if/when this is set TRUE.

Additional context
By default this will be set FALSE and thus shouldn't affect anything in the default/non-EDS workflows.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jan 31, 2024
jphickey added a commit to jphickey/cFE that referenced this issue Jan 31, 2024
@jphickey
Fix nasa#2507, add EDS cmake hooks
64f9a63 
Adds CFE_EDS_ENABLED_BUILD option at the top level, along with
other logic that is tied in only when this is set TRUE.

By default it is set to FALSE, so it does not change any existing
workflows yet.

Also added are the keys for two configuration values for reflecting
EDS DB objects (pointers) and some minor cleanup.
jphickey added a commit to jphickey/cFE that referenced this issue Jan 31, 2024
@jphickey
Fix nasa#2507, add EDS cmake hooks
5be417a 
Adds CFE_EDS_ENABLED_BUILD option at the top level, along with
other logic that is tied in only when this is set TRUE.

By default it is set to FALSE, so it does not change any existing
workflows yet.

Also added are the keys for two configuration values for reflecting
EDS DB objects (pointers) and some minor cleanup.
jphickey added a commit to jphickey/cFE that referenced this issue Feb 1, 2024
@jphickey
Fix nasa#2507, add EDS cmake hooks
76ee213 
Adds CFE_EDS_ENABLED_BUILD option at the top level, along with
other logic that is tied in only when this is set TRUE.

By default it is set to FALSE, so it does not change any existing
workflows yet.

Also added are the keys for two configuration values for reflecting
EDS DB objects (pointers) and some minor cleanup.
@jphickey jphickey mentioned this issue Feb 1, 2024
Merged
2 tasks
dzbaker added a commit that referenced this issue Feb 2, 2024
@dzbaker
Merge pull request #2511 from jphickey:fix-2507-eds-hooks
6355bc2 
Fix #2507, add EDS cmake hooks
@dzbaker dzbaker mentioned this issue Feb 2, 2024
Merged
2 tasks
@dzbaker dzbaker closed this as completed in 350f57e Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2507, add EDS cmake hooks jphickey/cFE
1 participant
@jphickey