Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct minor name inconsistencies in ES #2502

Closed
jphickey opened this issue Jan 25, 2024 · 0 comments · Fixed by #2505
Closed

Correct minor name inconsistencies in ES #2502

jphickey opened this issue Jan 25, 2024 · 0 comments · Fixed by #2505
Assignees

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There are some remaining naming convention inconsistencies in ES. Notably:

  1. CC definitions named _SYSLOG_CC should be _SYS_LOG_CC - because CamelCase version is SysLog, therefore it is two words, not one. Alternatively, CamelCase version could be Syslog, but that's probably a more significant change.
  2. The recently-added Perf Log enum does not follow convention. Labels should be e.g. CFE_ES_PerfTrigger_START, not CFE_ES_PERF_TRIGGER_START.

These are all just simple search/replace fixes.

Describe the solution you'd like
Rename symbols

Additional context
This inconsistency causes name mismatches when using generated headers, as the generated headers follow the conventions strictly.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Jan 25, 2024
jphickey added a commit to jphickey/cFE that referenced this issue Jan 25, 2024
Corrects cases where ES symbol names did not exactly match expected
conventions.
jphickey added a commit to jphickey/cFE that referenced this issue Jan 25, 2024
Corrects cases where ES symbol names did not exactly match expected
conventions.
jphickey added a commit to jphickey/cFE that referenced this issue Jan 25, 2024
Corrects cases where ES symbol names did not exactly match expected
conventions.
jphickey added a commit to jphickey/cFE that referenced this issue Jan 25, 2024
Corrects cases where symbol names in ES and TIME did not exactly match
the expected conventions.
jphickey added a commit to jphickey/cFE that referenced this issue Jan 25, 2024
Corrects cases where ES symbol names did not exactly match expected
conventions.
jphickey added a commit to jphickey/cFE that referenced this issue Jan 25, 2024
Corrects cases where ES symbol names did not exactly match expected
conventions.
jphickey added a commit to jphickey/cFE that referenced this issue Jan 29, 2024
Corrects cases where CFE symbol names did not exactly match expected
conventions.
jphickey added a commit to jphickey/cFE that referenced this issue Jan 29, 2024
Corrects cases where CFE symbol names did not exactly match expected
conventions.
dzbaker added a commit that referenced this issue Jan 31, 2024
Fix #2502, #2504, CFE updates needed for generated header compatibility (EDS)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant