You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The table building logic - i.e. the contents of cmake/tables directory here, along with business logic within of the add_cfe_tables function that calls the scripts and invokes the tool - are really dependent on the implementation of the table conversion tool (e.g. elf2cfetbl). A different tool will likely need different logic; the whole process of compiling into an ELF object and extracting that is really specific to the way elf2cfetbl works.
Describe the solution you'd like
The scripts and logic to compile a table and invoke the tool should really be version controlled with the table tool itself, not with CFE.
Describe alternatives you've considered
N/A
Additional context
Any time the table build procedure needs to be updated, it likely requires changes to the script in coordination with changes to the tool itself. Having the scripts with the tool just makes more sense in allowing those changes to be done atomically in one repo.
Also note that EDS uses a different tool to build tables - and required sprinkling if(CFE_EDS_ENABLED_BUILD) in a bunch of places in the add_cfe_tables() function. This would be much cleaner if the scripts were entirely separate.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The table building logic - i.e. the contents of
cmake/tables
directory here, along with business logic within of theadd_cfe_tables
function that calls the scripts and invokes the tool - are really dependent on the implementation of the table conversion tool (e.g.elf2cfetbl
). A different tool will likely need different logic; the whole process of compiling into an ELF object and extracting that is really specific to the way elf2cfetbl works.Describe the solution you'd like
The scripts and logic to compile a table and invoke the tool should really be version controlled with the table tool itself, not with CFE.
Describe alternatives you've considered
N/A
Additional context
Any time the table build procedure needs to be updated, it likely requires changes to the script in coordination with changes to the tool itself. Having the scripts with the tool just makes more sense in allowing those changes to be done atomically in one repo.
Also note that EDS uses a different tool to build tables - and required sprinkling
if(CFE_EDS_ENABLED_BUILD)
in a bunch of places in theadd_cfe_tables()
function. This would be much cleaner if the scripts were entirely separate.Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: