Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The include file wrapper script does not pick up a "cfe" prefix file #2391

Closed
jphickey opened this issue Jul 12, 2023 · 0 comments · Fixed by #2392 or nasa/cFS#685
Closed

The include file wrapper script does not pick up a "cfe" prefix file #2391

jphickey opened this issue Jul 12, 2023 · 0 comments · Fixed by #2392 or nasa/cFS#685

Comments

@jphickey
Copy link
Contributor

Describe the bug
The include file wrapper script looks for a name-qualified file to use for e.g. cfe_msgids.h and cfe_platform_cfg.h. This means that the file provided in the "defs" directory needs to be named based on the config, for example default_platform_cfg.h or cpu1_platform_cfg.h .. then this file gets wrapped as cfe_platform_cfg.h for C source files to use.

This pattern has some advantages, in that only one copy of a file actually named cfe_platform_cfg.h will exist on the disk, therefore it is clear(er) which one is actually getting picked up.

However, this name difference/mapping isn't well documented and can be confusing or unexpected to some users.

To Reproduce
Create a customized cfe_msgids.h file in the defs dir, and run "make prep"
Observe that the default msgids from CFE were picked up, not the customized version.

Expected behavior
The customized version should be picked up.

System observed on:
Debian

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Jul 12, 2023
jphickey added a commit that referenced this issue Jul 12, 2023
This allows the script to pick up the file if it was named simply
"cfe_msgids.h" or "cfe_platform_cfg.h", rather than insisting it be
named with a platform-specific prefix
dzbaker added a commit that referenced this issue Jul 12, 2023
Fix #2391, add cfe to prefix list for msgids.h and platform_cfg.h
dzbaker added a commit that referenced this issue Jul 12, 2023
Fix #2391, add cfe to prefix list for msgids.h and platform_cfg.h
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment