Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of Time1/Time2 TimeA/TimeB parameter names #2341

Open
2 tasks done
thnkslprpt opened this issue May 20, 2023 · 0 comments · May be fixed by #2342
Open
2 tasks done

Inconsistent use of Time1/Time2 TimeA/TimeB parameter names #2341

thnkslprpt opened this issue May 20, 2023 · 0 comments · May be fixed by #2342

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
CFE_TIME_Add() and CFE_TIME_Subtract() use Time1 and Time2 to name their time parameters.
CFE_TIME_Compare() uses TimeA and TimeB.
Was noted here but doesn't have an issue open that I could find.

Code snips

CFE_TIME_SysTime_t CFE_TIME_Add(CFE_TIME_SysTime_t Time1, CFE_TIME_SysTime_t Time2);

CFE_TIME_SysTime_t CFE_TIME_Subtract(CFE_TIME_SysTime_t Time1, CFE_TIME_SysTime_t Time2);

CFE_TIME_Compare_t CFE_TIME_Compare(CFE_TIME_SysTime_t TimeA, CFE_TIME_SysTime_t TimeB);

Expected behavior
Make consistent.

Reporter Info
Avi Weiss @thnkslprpt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants