TIME includes unnecessary asserts in invalid command length tests

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
TIME is the only module that also checks the command counters in the coverage tests for commands issued with an invalid length.

cFE/modules/time/ut-coverage/time_UT.c

Lines 1400 to 1408 in 7479d22

	/* Noop with bad size */
	UT_InitData();
	memset(&CmdBuf, 0, sizeof(CmdBuf));
	CFE_TIME_Global.CommandCounter = 0;
	CFE_TIME_Global.CommandErrorCounter = 0;
	UT_CallTaskPipe(CFE_TIME_TaskPipe, &CmdBuf.message, 0, UT_TPID_CFE_TIME_CMD_NOOP_CC);
	CFE_UtAssert_EVENTSENT(CFE_TIME_LEN_ERR_EID);
	UtAssert_UINT32_EQ(CFE_TIME_Global.CommandCounter, 0);
	UtAssert_UINT32_EQ(CFE_TIME_Global.CommandErrorCounter, 1);

The others:

cFE/modules/es/ut-coverage/es_UT.c

Lines 3337 to 3342 in 7479d22

	/* Test sending a no-op command with an invalid command length */
	ES_ResetUnitTest();
	UT_CallTaskPipe(CFE_ES_TaskPipe, &CmdBuf.Msg, 0, UT_TPID_CFE_ES_CMD_NOOP_CC);
	CFE_UtAssert_EVENTSENT(CFE_ES_LEN_ERR_EID);
	/* Test sending a reset counters command with an invalid command length */

cFE/modules/evs/ut-coverage/evs_UT.c

Lines 1775 to 1780 in 7479d22

	/* Test invalid command length event */
	UT_InitData_EVS();
	UT_EVS_DoDispatchCheckEvents(&cmd, 0, UT_TPID_CFE_EVS_CMD_NOOP_CC, &UT_EVS_EventBuf);
	UtAssert_UINT32_EQ(UT_EVS_EventBuf.EventID, CFE_EVS_LEN_ERR_EID);
	/* Test invalid command length with reset counters command */

cFE/modules/sb/ut-coverage/sb_UT.c

Lines 523 to 525 in 7479d22

	UT_CallTaskPipe(CFE_SB_ProcessCmdPipePkt, &Noop.SBBuf.Msg, 0, UT_TPID_CFE_SB_CMD_NOOP_CC);
	CFE_UtAssert_EVENTSENT(CFE_SB_LEN_ERR_EID);
	}

cFE/modules/tbl/ut-coverage/tbl_UT.c

Lines 306 to 313 in 7479d22

	/* Test command pipe messages handler response to an invalid
	* message length
	*/
	UT_InitData();
	UT_CallTaskPipe(CFE_TBL_TaskPipe, &CmdBuf.Msg, sizeof(CmdBuf.NoopCmd) - 1, UT_TPID_CFE_TBL_CMD_NOOP_CC);
	CFE_UtAssert_EVENTSENT(CFE_TBL_LEN_ERR_EID);
	/* Test command pipe messages handler response to an invalid

Expected behavior
Can simplify the unit tests for TIME by removing these extra asserts - checking for CFE_TIME_LEN_ERR_EID being sent seems sufficient.

Reporter Info
Avi Weiss @thnkslprpt