Fix #1528, Move NO_SUCH_TABLE_ERR_EID into FindTableInRegistry and make optional #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new CodeQL configuration |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -503,6 +503,14 @@ | |||
| } | |||
| } while ((RegIndx == CFE_TBL_NOT_FOUND) && (i < (CFE_PLATFORM_TBL_MAX_NUM_TABLES - 1))); | |||
|
|
|||
| #if (CFE_PLATFORM_TBL_SEND_EVENT_IF_TABLE_NOT_FOUND == true) | |||
Check notice
Code scanning / CodeQL
Conditional compilation
|
You have successfully added a new CodeQL configuration |
…d make optional
thnkslprpt
force-pushed
the
fix-1528-move-tbl-not-found-eid-into-FindTableInRegistry
branch
from
ae95ec6
to
da5663a
Compare
chillfig
approved these changes
Jun 29, 2023
|
No longer relevent after #2539 |
thnkslprpt
deleted the
fix-1528-move-tbl-not-found-eid-into-FindTableInRegistry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_TBL_NO_SUCH_TABLE_ERR_EIDevent fromCFE_TBL_FindTableInRegistry#1528CFE_TBL_NO_SUCH_TABLE_ERR_EIDfromcfe_tbl_task_cmds.cwhere calls toCFE_TBL_FindTableInRegistry()returnCFE_TBL_NOT_FOUND.(reducing code duplication)CFE_TBL_FindTableInRegistry()itselfCFE_PLATFORM_TBL_SEND_EVENT_IF_TABLE_NOT_FOUNDto switch the event report on (true) or off (false)Testing performed
GitHub CI actions all passing successfully.
Local tests with cFS suite confirm no net loss of coverage.
Note: quite a few tests had to have an event count incremented up one because 3 functions in
cfe_tbl_api.cwere callingCFE_TBL_FindTableInRegistry()but were not sending an event on failure (like those fromcfe_tbl_task_cmds.cwere). So any unit tests calling these functions (including downstream) with intentional failures to find the table now issue an event, where they did not do so previously.Expected behavior changes
Event reports of
CFE_TBL_NO_SUCH_TABLE_ERR_EIDare now all issued from withinCFE_TBL_FindTableInRegistry()and can be optionally switched on or off from within the platform config file.System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.
Contributor Info
Avi Weiss @thnkslprpt