Unnecessary duplicate 'if (status == CFE_SUCCESS)' check

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
CFE_EVS_EnableAppEventTypeCmd() and CFE_EVS_DisableAppEventTypeCmd() have a redundant repeat check of if (Status == CFE_SUCCESS).
Can be refactored to combine them, without any change to the underlying logic.

Expected behavior
Refactor to remove (unnecessary) duplicate if block.

Code snips

cFE/modules/evs/fsw/src/cfe_evs_task.c

Lines 981 to 1019 in 6d96c6e

	if (Status == CFE_SUCCESS)
	{
	/* Need to check for an out of range bitmask, since our bit masks are only 4 bits */
	if (CmdPtr->BitMask == 0x0 || CmdPtr->BitMask > 0x0F)
	{
	EVS_SendEvent(CFE_EVS_ERR_INVALID_BITMASK_EID, CFE_EVS_EventType_ERROR,
	"Bit Mask = 0x%08x out of range: CC = %lu", (unsigned int)CmdPtr->BitMask,
	(long unsigned int)CFE_EVS_ENABLE_APP_EVENT_TYPE_CC);
	Status = CFE_EVS_INVALID_PARAMETER;
	}
	else
	{
	EVS_EnableTypes(AppDataPtr, CmdPtr->BitMask);
	}
	}
	else if (Status == CFE_EVS_APP_NOT_REGISTERED)
	{
	EVS_SendEvent(CFE_EVS_ERR_APPNOREGS_EID, CFE_EVS_EventType_ERROR, "%s not registered with EVS: CC = %lu",
	LocalName, (long unsigned int)CFE_EVS_ENABLE_APP_EVENT_TYPE_CC);
	}
	else if (Status == CFE_EVS_APP_ILLEGAL_APP_ID)
	{
	EVS_SendEvent(CFE_EVS_ERR_ILLAPPIDRANGE_EID, CFE_EVS_EventType_ERROR,
	"Illegal application ID retrieved for %s: CC = %lu", LocalName,
	(long unsigned int)CFE_EVS_ENABLE_APP_EVENT_TYPE_CC);
	}
	else
	{
	EVS_SendEvent(CFE_EVS_ERR_NOAPPIDFOUND_EID, CFE_EVS_EventType_ERROR,
	"Unable to retrieve application ID for %s: CC = %lu", LocalName,
	(long unsigned int)CFE_EVS_ENABLE_APP_EVENT_TYPE_CC);
	}
	if (Status == CFE_SUCCESS)
	{
	EVS_SendEvent(CFE_EVS_ENAAPPEVTTYPE_EID, CFE_EVS_EventType_DEBUG,
	"Enable App Event Type Command Received with AppName = %s, EventType Bit Mask = 0x%02x",
	LocalName, CmdPtr->BitMask);
	}

Identical case for CFE_EVS_DisableAppEventTypeCmd().

Reporter Info
Avi Weiss @thnkslprpt

[thnkslprpt]

Closing as first case was already raised in #1450
Will combine both cases into that Issue/PR.