Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "workflow_dispatch" for any workflow that depends on an external action #2225

Closed
jphickey opened this issue Dec 6, 2022 · 0 comments · Fixed by #2236
Closed

Add "workflow_dispatch" for any workflow that depends on an external action #2225

jphickey opened this issue Dec 6, 2022 · 0 comments · Fixed by #2236
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

jphickey commented Dec 6, 2022

Is your feature request related to a problem? Please describe.
Currently, the existing github workflows are only triggered by pull request and push events. However, many of them use external workflows, mainly those defined in nasa/cFS bundle repo, and some 3rd party ones.

Problem is, when merging new code to the cFS bundle repo main branch, there is no way to re-run the cFE workflows against the updated main branch of cFS. Clicking the "Re-Run" button on the previous run doesn't work; it runs with the same bundle commitID as the original did. We need a way to run against the updated main branch of the cFS repo, even when the cFE repo may not have changed at all.

Currently the only way to trigger this is to make a bogus push to a fork, which will trigger the actions to run and will use the latest version.

Describe the solution you'd like
Add "workflow_dispatch" as an option to workflows - especially for anything that references an external workflow or action in the main branch that can in turn be updated outside the merge cycle of the local repo.

Additional context
This provides a simpler, cleaner method to re-validate the cFE workflows are still functioning after a change to the cFS repo.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

chillfig added a commit to chillfig/cFE that referenced this issue Jan 18, 2023
@chillfig chillfig self-assigned this Jan 18, 2023
chillfig added a commit to chillfig/cFE that referenced this issue Jan 18, 2023
chillfig added a commit to chillfig/cFE that referenced this issue Jan 19, 2023
chillfig added a commit to chillfig/cFE that referenced this issue Jan 19, 2023
dzbaker added a commit that referenced this issue Jan 20, 2023
Fix #2225, Adds workflow_dispatch to all workflows
@dmknutsen dmknutsen added this to the Draco milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants