Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce strict cast alignment #2205

Closed
skliper opened this issue Nov 10, 2022 · 0 comments · Fixed by #2206
Closed

Enforce strict cast alignment #2205

skliper opened this issue Nov 10, 2022 · 0 comments · Fixed by #2206
Assignees
@skliper
Labels
build-system draco-rc4
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Nov 10, 2022

Is your feature request related to a problem? Please describe.
Now that CI is upgraded to Ubuntu20, would be good to enforce strict cast alignment

Describe the solution you'd like
Update the cast-align line to read:
-Wcast-align=strict in https://github.com/nasa/cFE/blob/main/cmake/sample_defs/arch_build_custom.cmake

Describe alternatives you've considered
None

Additional context
Note it's fully compliant w/ this flag right now based on fixes done during Draco, but should enforce to avoid future issues.

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper self-assigned this Nov 10, 2022
skliper added a commit to skliper/cFE that referenced this issue Nov 10, 2022
@skliper
Fix nasa#2205, Enforce strict cast alignment on arch
d66c00e
@skliper skliper mentioned this issue Nov 10, 2022
Merged
2 tasks
dzbaker added a commit that referenced this issue Nov 23, 2022
@dzbaker
Merge pull request #2206 from skliper/fix2205-strict_cast_align
348a98b 
Fix #2205, Enforce strict cast alignment on arch
@dzbaker dzbaker mentioned this issue Nov 23, 2022
Merged
2 tasks
jphickey added a commit to skliper/cFE that referenced this issue Nov 23, 2022
@jphickey
Hotfix nasa#2205, apply strict cast-align to native builds only
b84dfbb 
The -Wcast-align=strict option only works with certain versions of gcc.
This moves it to the "native" custom options, so it will not be used on
cross builds.
dzbaker added a commit that referenced this issue Nov 28, 2022
@dzbaker
Merge pull request #2206 from skliper/fix2205-strict_cast_align
f724dbc 
Hotfix #2205, apply strict cast-align to native builds only
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
@dzbaker dzbaker mentioned this issue Apr 28, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
build-system draco-rc4
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #2205, Enforce strict cast alignment on arch skliper/cFE
2 participants
@skliper @dmknutsen