Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no way to find an existing pipe ID by name #210

Closed
skliper opened this issue Sep 30, 2019 · 14 comments · Fixed by #404 or #511
Closed

no way to find an existing pipe ID by name #210

skliper opened this issue Sep 30, 2019 · 14 comments · Fixed by #404 or #511
Assignees
@CDKnightNASA
Labels
enhancement
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

There is no way to find a pipe ID given a pipe name for an existing pipe.
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 179. Created by cdknight on 2017-01-31T13:25:42, last modified: 2019-06-10T15:59:59

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2017-01-31 17:44:15:

proposed change committed to [changeset:4438cb8] in branch trac-179-getpipeidbyname

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-03-01 08:07:20:

CCB ready for code review (note, needs rebase to dev branch).

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-03-26 13:11:19:

May be impacted by #288

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2019-03-27 11:03:00:

Will re-implement using OS_QueueGetIdByName

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2019-04-03 14:20:35:

Committed to a new branch, trac-179-getpipeidbyname_osqueue changeset [changeset:6124aa4].

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-04-18 16:42:22:

Did you add a unit test stub for the new function for apps to use? Added as a topic for 4/24 CCB review.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2019-04-18 16:53:58:

Yes, it is in the commit.

Replying to [comment:7 jhageman]:

Did you add a unit test stub for the new function for apps to use? Added as a topic for 4/24 CCB review.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2019-04-18 16:55:07:

Oh sorry no I haven't added a stub. I hope to be able to add it by the CCB. Busy week for me this week!

Replying to [comment:8 cdknight]:

Yes, it is in the commit.

Replying to [comment:7 jhageman]:

Did you add a unit test stub for the new function for apps to use? Added as a topic for 4/24 CCB review.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2019-04-23 11:39:11:

I don't believe this should have a stub...For example, CFE_SB_GetLastSenderId() does not have a stub. The unit tests cover all of the functionality of CFE_SB_GetPipeIdByName() without requiring a stub and no other unit tests need to use CFE_SB_GetPipeIdByName().

Replying to [comment:9 cdknight]:

Oh sorry no I haven't added a stub. I hope to be able to add it by the CCB. Busy week for me this week!

Replying to [comment:8 cdknight]:

Yes, it is in the commit.

Replying to [comment:7 jhageman]:

Did you add a unit test stub for the new function for apps to use? Added as a topic for 4/24 CCB review.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2019-04-24 13:02:52:

Per CCB discussion, all API's need to have stubs. I will write and push an update.

Replying to [comment:10 cdknight]:

I don't believe this should have a stub...For example, CFE_SB_GetLastSenderId() does not have a stub. The unit tests cover all of the functionality of CFE_SB_GetPipeIdByName() without requiring a stub and no other unit tests need to use CFE_SB_GetPipeIdByName().

Replying to [comment:9 cdknight]:

Oh sorry no I haven't added a stub. I hope to be able to add it by the CCB. Busy week for me this week!

Replying to [comment:8 cdknight]:

Yes, it is in the commit.

Replying to [comment:7 jhageman]:

Did you add a unit test stub for the new function for apps to use? Added as a topic for 4/24 CCB review.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-06-10 13:01:23:

Dropping from CCB list until stubs are added. Moving it back to assigned since work remains to be completed.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2019-06-10 15:42:04:

hi, stub was added in [[changeset:19cb0c1]]

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-06-10 15:59:59:

Looks like stub was based on code prior to merge of #116, needs rebase and update to match preferred ut_assert style.

@skliper skliper assigned CDKnightNASA and unassigned skliper Sep 30, 2019
@skliper skliper mentioned this issue Sep 30, 2019
Closed
@CDKnightNASA CDKnightNASA mentioned this issue Nov 13, 2019
Merged
skliper added a commit to CDKnightNASA/cFE that referenced this issue Jan 14, 2020
@skliper
Fix nasa#210, Add SB APIs related to pipe name
f9b3e31 
Moves CFE_SB_GetPipeName to public API
Adds  CFE_SB_GetPipeIdByName
Adds 6 related events
Adds to SB HK packet (GetPipeIdByNameErrorCounter)
Updates associated internal name logic
Unit tests and stubs added
CDKnightNASA added a commit to CDKnightNASA/cFE that referenced this issue Jan 21, 2020
@CDKnightNASA
Fix for issue nasa#210
3916896 
Moves CFE_SB_GetPipeName to public API
Adds  CFE_SB_GetPipeIdByName
Adds 6 related events
Adds to SB HK packet (GetPipeIdByNameErrorCounter)
Updates associated internal name logic
Unit tests and stubs added
CDKnightNASA added a commit to CDKnightNASA/cFE that referenced this issue Jan 21, 2020
@CDKnightNASA
Fix for issue nasa#210
302b68a 
Moves CFE_SB_GetPipeName to public API
Adds CFE_SB_GetPipeIdByName
Adds 6 related events
Adds to SB HK packet (GetPipeIdByNameErrorCounter)
Updates associated internal name logic
Unit tests and stubs added
@astrogeco astrogeco linked a pull request Feb 11, 2020 that will close this issue
Fix #210, Add SB API to get pipe by name #404
Merged
astrogeco added a commit that referenced this issue Feb 12, 2020
@astrogeco
Merge pull request #404 from CDKnightNASA/fix-210-getpipidbyname
b9269fa 
Fix #210, Add SB API to get pipe by name
astrogeco added a commit that referenced this issue Feb 12, 2020
@astrogeco
Merge pull request #404 from CDKnightNASA/fix-210-getpipidbyname
570ed6f 
Fix #210, Add SB API to get pipe by name
@astrogeco astrogeco mentioned this issue Feb 12, 2020
Merged
@skliper skliper mentioned this issue Feb 20, 2020
Closed
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CDKnightNASA CDKnightNASA

Labels
enhancement
Projects
None yet
Milestone
Bootes
2 participants
@CDKnightNASA @skliper