Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax CMake directory expectations for elf2cfetbl #1907

Open
astrogeco opened this issue Aug 27, 2021 · 2 comments
Open

Relax CMake directory expectations for elf2cfetbl #1907

astrogeco opened this issue Aug 27, 2021 · 2 comments

Comments

@astrogeco
Copy link
Contributor

astrogeco commented Aug 27, 2021

Is your feature request related to a problem? Please describe.
See conversation in nasa/cFS#319

From a dependency / scope standpoint, the cfe_add_tables() function really wants to be defined along with the table tool sources themselves. Then, after finding the table source directory, the cFE CMake infrastructure could import implementations of those cmake functions which are tool-specific. Then cFE and table generation can be decoupled via the cfe_add_tables() interface. In that way, different implementations for cfe_add_tables() can be used depending on the mission config.

Describe the solution you'd like

Create a modifiable CMAKE parameter for the location of elf2cfetbl so users can design custom directory structures

Describe alternatives you've considered

Long-term, let users define custom toolchain compositions using tools other than elf2cfetbl

Additional context
See above

paulober pushed a commit to paulober/cFE that referenced this issue Aug 29, 2021
Cmake option to change the path of the ef2cfetbl executable file via the TABLETOOL_EXE environment variable. This also enables the user to specify other tools as table tool if needed.
paulober pushed a commit to paulober/cFE that referenced this issue Aug 30, 2021
Cmake option to change the path of the ef2cfetbl executable file via the TABLETOOL_EXE environment variable. This also enables the user to specify other tools as table tool if needed.
paulober pushed a commit to paulober/cFE that referenced this issue Aug 31, 2021
Cmake option to change the path of the ef2cfetbl executable file via the TABLETOOL_EXE environment variable. This also enables the user to specify other tools as table tool if needed.
@astrogeco
Copy link
Contributor Author

astrogeco commented Aug 31, 2021

@jphickey here's the issue I wrote regarding elf2cfetbl

@jbohren-hbr
Copy link
Contributor

@astrogeco I'm down with having a deeper conversation around how to address this in a scalable way.

What do you think about making the add_cfe_tables() function pluggable? It could be defined by whichever project implements the table tool (e.g. elf2cfetbl or eds2cfetbl), and then the CMake function definition could be include()ed in arch_build.cmake.

paulober pushed a commit to paulober/cFE that referenced this issue Aug 31, 2021
Cmake option to change (on mission build) the path of the ef2cfetbl executable file tought the -DTABLETOOL_EXECUTABLE cmake argument. This also enables the user to specify other tools as table tool if needed.
paulober pushed a commit to paulober/cFE that referenced this issue Aug 31, 2021
Cmake option to change (on mission build) the path of the ef2cfetbl executable file tought the -DTABLETOOL_EXECUTABLE cmake argument. This also enables the user to specify other tools as table tool if needed.
paulober pushed a commit to paulober/cFE that referenced this issue Aug 31, 2021
Cmake option to change (on mission build) the path of the ef2cfetbl executable file tought the -DTABLETOOL_EXECUTABLE cmake argument. This also enables the user to specify other tools as table tool if needed.
paulober pushed a commit to paulober/cFE that referenced this issue Aug 31, 2021
Cmake option to change (on mission build) the path of the ef2cfetbl executable file tought the -DTABLETOOL_EXECUTABLE cmake argument. This also enables the user to specify other tools as table tool if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants