Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cFE_FTAssert_VOIDCALL with new UtAssert_VOIDCALL #1774

Closed
astrogeco opened this issue Aug 9, 2021 · 1 comment · Fixed by #1796 or #1772
Closed

Replace cFE_FTAssert_VOIDCALL with new UtAssert_VOIDCALL #1774

astrogeco opened this issue Aug 9, 2021 · 1 comment · Fixed by #1796 or #1772
Assignees
@jphickey
Labels
good first issue Good for newcomers unit-test
Milestone
Caelum

Comments

@astrogeco
Copy link
Contributor

astrogeco commented Aug 9, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

The cFE Functional Test use a macro called cFE_FTAssert_VOIDCALL. That macro should be deleted and all existing references to it replaced with UtAssert_VOIDCALL.

Describe the solution you'd like

Replace old macro.

Describe alternatives you've considered
Leave as is.

Additional context
See #1744 (comment)
@astrogeco astrogeco added good first issue Good for newcomers unit-test labels Aug 9, 2021
@zanzaben
Copy link
Contributor

zanzaben commented Aug 9, 2021

The cFE Functional Test use a macro called cFE_FTAssert_VOIDCALL. That macro should be deleted and all existing references to it replaced with UtAssert_VOIDCALL.

@skliper skliper added this to the 7.0.0 milestone Aug 9, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Aug 10, 2021
@jphickey
Fix nasa#1774, replace VOIDCALL assert macro
676c473 
Use the generic UtAssert_VOIDCALL macro now provided from UtAssert,
rather than a local macro in cfe_testcase app.
@jphickey jphickey mentioned this issue Aug 10, 2021
Merged
astrogeco added a commit that referenced this issue Aug 10, 2021
@astrogeco
Merge pull request #1796 from jphickey/fix-1774-replace-voidcall-macro
25112ec 
Fix #1774, replace VOIDCALL assert macro
@astrogeco astrogeco mentioned this issue Aug 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
good first issue Good for newcomers unit-test
Projects
None yet
Milestone
Caelum
4 participants
@zanzaben @jphickey @skliper @astrogeco