Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Resource ID functional test to check maximum #1760

Closed
astrogeco opened this issue Aug 4, 2021 · 3 comments · Fixed by #1804 or #1808
Closed

Write Resource ID functional test to check maximum #1760

astrogeco opened this issue Aug 4, 2021 · 3 comments · Fixed by #1804 or #1808
Assignees
@nmullane
Labels
unit-test
Milestone
Caelum

Comments

@astrogeco
Copy link
Contributor

astrogeco commented Aug 4, 2021 •
edited by jphickey
Loading

Is your feature request related to a problem? Please describe.
Need open source functional tests for certifiability

Describe the solution you'd like
Add additional checks to functional tests for ES Resource ID to Index that ensure the returned index is less than the maximum allowed for that resource type

Describe alternatives you've considered
None

Requester Info
Originally posted by @astrogeco in #1734 (comment)
@skliper skliper added this to the 7.0.0 milestone Aug 4, 2021
nmullane added a commit to nmullane/cFE that referenced this issue Aug 5, 2021
@nmullane
Fix nasa#1760, check resource ID idx is less than max
6dd0b83
@nmullane
Copy link
Contributor

nmullane commented Aug 5, 2021

I'll work on this.

@nmullane
Copy link
Contributor

nmullane commented Aug 5, 2021

I can't edit the issue text, so should I create a new issue with a fleshed out description? Or the following can just be copied into this issue's description

Is your feature request related to a problem? Please describe.
Need open source functional tests for certifiability

Describe the solution you'd like
Add additional checks to functional tests for ES Resource ID to Index that ensure the returned index is less than the maximum allowed for that resource type

Describe alternatives you've considered
None

Requester Info
Niall Mullane - GSFC 582 Intern

@jphickey
Copy link
Contributor

jphickey commented Aug 5, 2021

I was able to update the description text. I'll watch for the PR and review. Thanks!

nmullane added a commit to nmullane/cFE that referenced this issue Aug 9, 2021
@nmullane
Fix nasa#1760, check resource ID idx is less than max
2afa72e
@nmullane nmullane mentioned this issue Aug 9, 2021
Merged
nmullane added a commit to nmullane/cFE that referenced this issue Aug 11, 2021
@nmullane
Fix nasa#1760, check resource ID idx is less than max
e2fcf9e
@nmullane nmullane mentioned this issue Aug 11, 2021
Merged
nmullane added a commit to nmullane/cFE that referenced this issue Aug 12, 2021
@nmullane
Fix nasa#1760, check resource ID idx is less than max
6214ff2 
- Also deletes the created gen counter in TestCounterIDToIndex to clean
up
astrogeco added a commit that referenced this issue Aug 13, 2021
@astrogeco
Merge pull request #1804 from nmullane/fix1760-check-maximum-resource…
5fd8c21 
…-id-index

Fix #1760, check resource ID idx is less than max
@astrogeco astrogeco mentioned this issue Aug 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmullane nmullane

Labels
unit-test
Projects
None yet
Milestone
Caelum
4 participants
@nmullane @jphickey @skliper @astrogeco