Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "count" global to test global struct #1733

Closed
jphickey opened this issue Jul 30, 2021 · 0 comments · Fixed by #1737 or #1772
Closed

Move "count" global to test global struct #1733

jphickey opened this issue Jul 30, 2021 · 0 comments · Fixed by #1737 or #1772
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

jphickey commented Jul 30, 2021

Describe the bug
Should not have random global variables around, particularly variables with simple/common names, as it may silently overwrite an existing variable (i.e. if any other app/lib makes a global called "count" some OS's will just happily bind to the existing variable, not make a separate instance, when dynamic refs are resolved after loading).

Expected behavior
Now that we have a proper global struct, CFE_FT_Global_t - This should be moved into it.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the bug label Jul 30, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue Aug 4, 2021
astrogeco added a commit that referenced this issue Aug 6, 2021
Fix #1733, Move global count into test global struct.
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants