You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
It's not clear from the API where the file offset is left after using any of the FS APIs that access the file:
CFE_FS_ReadHeader
CFE_FS_WriteHeader
CFE_FS_SetTimestamp
Describe the solution you'd like
Right now, at least some apps in the wild depend on current behavior so preferred fix for Caelum is just to document current behavior (success and error). Error can be undefined, but success should be consistent/explicit.
Also worth adding a functional check to confirm this behavior (if it's not already checked).
Describe alternatives you've considered
Could explicitly be undefined, or change behavior to reset to the start of the file but that would ripple through all the apps.
Additional context
From an app code review, currently undocumented behavior means apps should all lseek but rather than change every app it's likely better to document the current behavior explicitly in the API.
Requester Info
Jacob Hageman - NASA/GSFC, ping @ejtimmon
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
It's not clear from the API where the file offset is left after using any of the FS APIs that access the file:
CFE_FS_ReadHeader
CFE_FS_WriteHeader
CFE_FS_SetTimestamp
Describe the solution you'd like
Right now, at least some apps in the wild depend on current behavior so preferred fix for Caelum is just to document current behavior (success and error). Error can be undefined, but success should be consistent/explicit.
Also worth adding a functional check to confirm this behavior (if it's not already checked).
Describe alternatives you've considered
Could explicitly be undefined, or change behavior to reset to the start of the file but that would ripple through all the apps.
Additional context
From an app code review, currently undocumented behavior means apps should all lseek but rather than change every app it's likely better to document the current behavior explicitly in the API.
Requester Info
Jacob Hageman - NASA/GSFC, ping @ejtimmon
The text was updated successfully, but these errors were encountered: