Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CFE_TIME_ClockState_Enum_t in cmd/tlm and handling #1546

Closed
skliper opened this issue May 17, 2021 · 0 comments · Fixed by #2001
Closed

Use CFE_TIME_ClockState_Enum_t in cmd/tlm and handling #1546

skliper opened this issue May 17, 2021 · 0 comments · Fixed by #2001

Comments

@skliper
Copy link
Contributor

skliper commented May 17, 2021

Is your feature request related to a problem? Please describe.
Defined as int16 even though a type is available:

void CFE_TIME_SetState(int16 NewState)

int16 ClockState;

int16 PendingState;

void CFE_TIME_SetState(int16 NewState);

int16 ClockState; /**< \brief #CFE_TIME_ClockState_INVALID=Spacecraft time has not been accurately set,
#CFE_TIME_ClockState_VALID=Spacecraft clock has been accurately set,
#CFE_TIME_ClockState_FLYWHEEL=Force into FLYWHEEL mode */

int16 AtToneState; /**< \brief Clock state at time of tone */

int16 ClockStateAPI; /**< \cfetlmmnemonic \TIME_APISTATE
\brief API State */

int16 ClockStateAPI; /**< \cfetlmmnemonic \TIME_APISTATE
\brief Clock state as per API */

CFE_TIME_Global.HkPacket.Payload.ClockStateAPI = (int16)CFE_TIME_CalculateState(Reference);

int16 CFE_TIME_CalculateState(const CFE_TIME_Reference_t *Reference)

int16 CFE_TIME_CalculateState(const CFE_TIME_Reference_t *Reference);

Describe the solution you'd like
Use CFE_TIME_ClockState_Enum_t

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

@astrogeco astrogeco added this to the cFS-Draco milestone Jul 20, 2021
astrogeco added a commit to astrogeco/cFE that referenced this issue Oct 19, 2021
Fix nasa#1546, use cfe time clock state enum t in cmd/tlm and handling
astrogeco added a commit to astrogeco/cFE that referenced this issue Oct 19, 2021
…ME-ClockState-Enum-t-in-cmd/tlm-and-handling

Fix nasa#1546, use cfe time clock state enum t in cmd/tlm and handling nasa#1663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants