Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_TIME_QueryResetVars misnomer #1543

Open
skliper opened this issue May 17, 2021 · 1 comment · May be fixed by #2497
Open

CFE_TIME_QueryResetVars misnomer #1543

skliper opened this issue May 17, 2021 · 1 comment · May be fixed by #2497
Labels
CFS-43 enhancement

Comments

@skliper
Copy link
Contributor

skliper commented May 17, 2021

Is your feature request related to a problem? Please describe.
CFE_TIME_QueryResetVars actually reads in and sets variables, so "Query" isn't a great verb to use.

Describe the solution you'd like
Rename (maybe RestoreFrom or similar)

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@thnkslprpt
Copy link
Contributor

Yes @skliper, I think RestoreFromResetVars or RestoreFromTimeResetVars would be suitable and have clearer meaning.

thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Jan 16, 2024
@thnkslprpt
Fix nasa#1543, Rename CFE_TIME_QueryResetVars to `CFE_TIME_RestoreF…
0240673 
…romTimeResetVars`
@thnkslprpt thnkslprpt linked a pull request Jan 16, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-43 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1543, Rename CFE_TIME_QueryResetVars to CFE_TIME_RestoreFromTimeResetVars thnkslprpt/cFE
2 participants
@thnkslprpt @skliper