Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"NULL" entry no longer supported for libraries in startup script #1505

Closed
skliper opened this issue May 11, 2021 · 0 comments · Fixed by #1520 or #1568
Closed

"NULL" entry no longer supported for libraries in startup script #1505

skliper opened this issue May 11, 2021 · 0 comments · Fixed by #1520 or #1568
Assignees
Labels
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented May 11, 2021

Describe the bug
Set sample_lib entry point to NULL:

OS_GenericSymbolLookup_Impl():118:Error: NULL: ./cf/sample_lib.so: undefined symbol: NULL
1980-012-14:04:03.48915 ES Startup: Could not find symbol:NULL. EC = 0xFFFFFFFF

To Reproduce
See above.

Expected behavior
NULL should skip the symbol lookup and load. Note it does skip if the field is just left empty, as in:
CFE_LIB, /cf/fs_lib.so, , FS_LIB, 0, 0, 0x0, 0;

Code snips
Only skips if empty string:

if (ReturnCode == CFE_SUCCESS && LoadParams->InitSymbolName[0] != 0)

Probably could just convert "NULL" to empty in the CFS_LIB processing section.

System observed on:

  • Hardware: Docker
  • OS: Ubuntu 18.04
  • Versions: Bundle main

Additional context
Found by @excaliburtb

Reporter Info
Jacob Hageman - NASA/GSFC

@skliper skliper added the bug label May 11, 2021
@skliper skliper added this to the 7.0.0 milestone May 11, 2021
jphickey added a commit to jphickey/cFE that referenced this issue May 13, 2021
Recognize the special string "NULL" to indicate no entry point
should be called for the library.  Equivalent to leaving the
field empty.
astrogeco added a commit that referenced this issue May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants