You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The CFE_BIT, CFE_SET, CFE_CLR, CFE_TST are all only used within cFE for avoiding recursion in SB, all just once except CFE_BIT
Describe the solution you'd like
Remove unnecessary macro, clearer to just use the expression vs an abstraction like everywhere else bits are set, cleared, tested. Coding standards encourage avoiding overuse of macros.
Describe alternatives you've considered
Could replace with inline functions and provide as a general utility (SB scope isn't all that intuitive), and use it more consistently. These aren't thread safe, if they are maintained consider atomic bit ops.
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The
CFE_BIT
,CFE_SET
,CFE_CLR
,CFE_TST
are all only used within cFE for avoiding recursion in SB, all just once exceptCFE_BIT
Describe the solution you'd like
Remove unnecessary macro, clearer to just use the expression vs an abstraction like everywhere else bits are set, cleared, tested. Coding standards encourage avoiding overuse of macros.
Describe alternatives you've considered
Could replace with inline functions and provide as a general utility (SB scope isn't all that intuitive), and use it more consistently. These aren't thread safe, if they are maintained consider atomic bit ops.
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: