Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/replace/rework CFE_BIT related macros #1453

Open
skliper opened this issue Apr 29, 2021 · 0 comments · May be fixed by #2294
Open

Remove/replace/rework CFE_BIT related macros #1453

skliper opened this issue Apr 29, 2021 · 0 comments · May be fixed by #2294

Comments

@skliper
Copy link
Contributor

skliper commented Apr 29, 2021

Is your feature request related to a problem? Please describe.
The CFE_BIT, CFE_SET, CFE_CLR, CFE_TST are all only used within cFE for avoiding recursion in SB, all just once except CFE_BIT

Describe the solution you'd like
Remove unnecessary macro, clearer to just use the expression vs an abstraction like everywhere else bits are set, cleared, tested. Coding standards encourage avoiding overuse of macros.

Describe alternatives you've considered
Could replace with inline functions and provide as a general utility (SB scope isn't all that intuitive), and use it more consistently. These aren't thread safe, if they are maintained consider atomic bit ops.

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant