Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace magic number in CFE_FS_WriteHeader with CFE_FS_FILE_CONTENT_ID #1441

Closed
skliper opened this issue Apr 28, 2021 · 0 comments · Fixed by #1556 or #1584
Closed

Replace magic number in CFE_FS_WriteHeader with CFE_FS_FILE_CONTENT_ID #1441

skliper opened this issue Apr 28, 2021 · 0 comments · Fixed by #1556 or #1584

Comments

@skliper
Copy link
Contributor

skliper commented Apr 28, 2021

Is your feature request related to a problem? Please describe.
Magic number:

/* put the header, 'cfe1' in hex, in to the content type */
Hdr->ContentType = 0x63464531;

Describe the solution you'd like
There's already a define, use it:

#define CFE_FS_FILE_CONTENT_ID 0x63464531 /**< \brief Magic Number for cFE compliant files (= 'cFE1') */

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 7.0.0 milestone Apr 28, 2021
@zanzaben zanzaben self-assigned this May 20, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue May 20, 2021
astrogeco added a commit that referenced this issue May 27, 2021
…agic_number

Fix #1441, Replace Header Content Type magic number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants