We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug A check for the "NumBuckets" member should be <= but it is using <.
<=
<
To Reproduce Attempt to validate PoolID 1 which uses the max number of buckets. Function returns false, but record is valid.
Expected behavior CFE_ES_GenPoolValidateState() should return true if using the max number of buckets (17 by default).
Code snips One-liner here:
cFE/modules/es/fsw/src/cfe_es_generic_pool.c
Line 604 in 98bc158
System observed on: Ubuntu 20.04
Reporter Info Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
Fix nasa#1270, limit check in pool validation
c1de7f4
It is OK/valid if NumBuckets is the maximum value
Should a unit test be added to confirm this case works?
Sorry, something went wrong.
Merge pull request #1271 from jphickey/fix-1270-pool-check
de01f9e
Fix #1270, limit check in pool validation
jphickey
Successfully merging a pull request may close this issue.
Describe the bug
A check for the "NumBuckets" member should be
<=
but it is using<
.To Reproduce
Attempt to validate PoolID 1 which uses the max number of buckets. Function returns false, but record is valid.
Expected behavior
CFE_ES_GenPoolValidateState() should return true if using the max number of buckets (17 by default).
Code snips
One-liner here:
cFE/modules/es/fsw/src/cfe_es_generic_pool.c
Line 604 in 98bc158
System observed on:
Ubuntu 20.04
Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: