Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry Point function name too long #1223

Closed
zanzaben opened this issue Mar 16, 2021 · 5 comments · Fixed by #1242 or #1258
Closed

Entry Point function name too long #1223

zanzaben opened this issue Mar 16, 2021 · 5 comments · Fixed by #1242 or #1258
Assignees
Milestone

Comments

@zanzaben
Copy link
Contributor

zanzaben commented Mar 16, 2021

Describe the bug
When trying to run the cfe test runner I got this error

1980-012-14:03:20.46280 ES Startup: Loading file: /cf/cfe_testrunner.so, APP: TESTRUN_APP
OS_GenericSymbolLookup_Impl():118:Error: CFE_TestRunner_AppM: ./cf/cfe_testrunner.so: undefined symbol: CFE_TestRunner_AppM
1980-012-14:03:20.46306 ES Startup: Could not find symbol:CFE_TestRunner_AppM. EC = 0xFFFFFFFF

It should be trying to use CFE_TestRunner_AppMain but is getting truncated at 19 characters.
When I shortened the function name it worked fine.

To Reproduce

  1. add the start test scripts for the startup test. Found Here
  2. Start it.

Expected behavior
It should run the tests.

System observed on:
Ubuntu 20.04

Reporter Info
Alex Campbell GSFC

@zanzaben
Copy link
Contributor Author

@jphickey should CFE_TestRunner_AppMain be shortened to something like CFE_TestRunner_AM or should it be able to work with function names longer than 19 characters?

@jphickey
Copy link
Contributor

Since AppMain suffix is used elsewhere (sample apps, LAB apps, etc), how about CFETR_AppMain?

@zanzaben zanzaben self-assigned this Mar 17, 2021
@jphickey
Copy link
Contributor

Another option - drop the CFE, because in reality it can be used for apps too - and call it TestRunner_AppMain

@skliper
Copy link
Contributor

skliper commented Mar 17, 2021

I like CFE_TR_AppMain since it's provided by CFE

@zanzaben
Copy link
Contributor Author

I think CFE_TR_AppMain is the most consistent with other function names.

zanzaben added a commit to zanzaben/cFE that referenced this issue Mar 18, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue Mar 25, 2021
astrogeco added a commit that referenced this issue Mar 29, 2021
Fix #1223, #1264 shorten TestRunner function name and update cfe_es_startup.scr docs
zanzaben added a commit to zanzaben/cFE that referenced this issue Mar 29, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment