Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All CMD/TLM messages should put content in a "Payload" sub-structure #99

Closed
3 tasks done
havencarlson opened this issue Aug 1, 2023 · 0 comments · Fixed by #100
Closed
3 tasks done

All CMD/TLM messages should put content in a "Payload" sub-structure #99

havencarlson opened this issue Aug 1, 2023 · 0 comments · Fixed by #100

Comments

@havencarlson
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
To match the patterns used in CFE and other modules, all CMD/TLM message definitions should put the content (non-header) parts into a separate struct called "Payload".

Describe the solution you'd like
Separate message content into a sub structure called "Payload".

Additional context
This is benefit to tooling that can use the presence of this field to identify where the actual content starts (e.g. something like offsetof(MsgType, Payload) would work and be correct, as opposed to checking sizeof(CFE_MSG_CommandHeader_t) which may not actually reflect where the content starts due to possible compiler-added padding between them).

Requester Info
Haven Carlson - NASA

@havencarlson havencarlson self-assigned this Aug 1, 2023
havencarlson added a commit to havencarlson/SC that referenced this issue Aug 2, 2023
havencarlson added a commit to havencarlson/SC that referenced this issue Aug 2, 2023
havencarlson added a commit to havencarlson/SC that referenced this issue Aug 2, 2023
havencarlson added a commit to havencarlson/SC that referenced this issue Aug 2, 2023
havencarlson added a commit to havencarlson/SC that referenced this issue Sep 1, 2023
dzbaker added a commit that referenced this issue Sep 1, 2023
Fix #99, cmd and tlm messages use payload sub-structure
@chillfig chillfig added this to the Equuleus milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants