Fix #80, Unit tests read past array bounds and general cleanup

[skliper]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].

Describe the contribution

• Fix SC_LoadAts_Test_AtsEntryOverflow Unit Test indexes past array bounds #80

Also consolidated "result" asserts using modern APIs, removed low-value/high-maintenance checks on event string and type (ID is sufficient to confirm path).

Recommend a follow-on issue to replace the rest of the UtAssert_True uses.

Testing performed
CI (including coverage)

Expected behavior changes
Greatly reduced technical debt wrt unit tests (large reduction in lines, and consistent table initialization)

System(s) tested on
CI

Additional context
Note this should make the remaining bug fixes and updates easier, by reducing ut change overhead.

Could squash if CCB wants, just tried to break down the changes a little.

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

[jphickey]

In retrospect I don't know why we didn't merge this into equuleus-rc1. I guess I didn't realize at the time we reviewed how horrendously broken the tests were. At the same time we were trying to limit new stuff in the build and this looked like a big change. Although they somehow ran most of the time, I see now that the tests were quite bad, we really should have merged this right away.

We need to somehow encourage stakeholders to update their SC now....