Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack smashing in AtsEntryOverflow test #102

Closed
2 tasks done
jphickey opened this issue Sep 12, 2023 · 1 comment · Fixed by #103
Closed
2 tasks done

Stack smashing in AtsEntryOverflow test #102

jphickey opened this issue Sep 12, 2023 · 1 comment · Fixed by #103
Assignees
@jphickey
Labels
bug

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
It appears this test case takes things a bit too literally - it creates an ATS buffer on the stack, then writes past the end of it.

To Reproduce
Execute the SC "loads" coverage test with stack protection enabled. This will abort due to stack corruption.

Expected behavior
Should execute successfully.

System observed on:
Debian

Additional context
The test case cannot literally overrun the buffer. It should just initialize the ATS so it looks like it will overrun the buffer - that is, set the length field too large - without writing those bytes.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Sep 12, 2023
@jphickey jphickey added the bug label Sep 12, 2023
@skliper
Copy link
Contributor

skliper commented Sep 12, 2023

Is this still the case after the following?

jphickey added a commit to jphickey/SC that referenced this issue Sep 15, 2023
@jphickey
Fix nasa#102, clean up sc_loads_test
a73c783 
Significant buffer management issues existed in many/all of these test
cases and was causing stack corruption.  Rewriting the test cases to
better follow current recommended practices, and reduce repetition.
@jphickey jphickey mentioned this issue Sep 15, 2023
Merged
2 tasks
jphickey added a commit to jphickey/SC that referenced this issue Sep 15, 2023
@jphickey
Fix nasa#102, clean up sc_loads_test
dc5df81 
Major buffer overrun issues were already fixed, but this further cleans
up the test cases to avoid repetition and better follow current
recommended practices.
jphickey added a commit to jphickey/SC that referenced this issue Sep 20, 2023
@jphickey
Fix nasa#102, clean up sc_loads_test
bb01c1f 
Major buffer overrun issues were already fixed, but this further cleans
up the test cases to avoid repetition and better follow current
recommended practices.
jphickey added a commit to jphickey/SC that referenced this issue Oct 9, 2023
@jphickey
Fix nasa#102, clean up sc_loads_test
99a6806 
Major buffer overrun issues were already fixed, but this further cleans
up the test cases to avoid repetition and better follow current
recommended practices.
dzbaker added a commit that referenced this issue Oct 10, 2023
@dzbaker
Merge pull request #103 from jphickey/fix-102-loads-test
7587a8c 
Fix #102, clean up sc_loads_test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #102, clean up sc_loads_test jphickey/SC
2 participants
@jphickey @skliper