Merge pull request #77 from thnkslprpt/fix-76-uninitialized-variable-…

…warning Fix #76, Squash static analysis (CodeQL) uninitialized variable warning
nasa · Jun 1, 2023 · d2565d6 · d2565d6
2 parents 6641ed3 + 6ceaa98
commit d2565d6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/docs/dox_src/cfs_sc.dox b/docs/dox_src/cfs_sc.dox
@@ -504,7 +504,7 @@
   time tag in the overlap region (including the switch command) this logic 
   does not get used. In either case, the switch can be performed without 
   sending any duplicate commands to be sent out. There are certain conditions 
-  that can cause a ATS switch that is pending to be canceled. If the ATP is 
+  that can cause an ATS switch that is pending to be canceled. If the ATP is 
   stopped by the ground while the ATP is waiting for a "safe" time to switch, 
   then the switch will not occur. Also if the ATP detects the end of the ATS 
   buffer before there is a "safe" time to switch, the switch will be canceled. 

diff --git a/fsw/inc/sc_events.h b/fsw/inc/sc_events.h
@@ -439,7 +439,7 @@
  *  \par Type: ERROR
  *
  *  \par Cause:
- *  This event message is issued when a ATS command that was about to be sent out
+ *  This event message is issued when an ATS command that was about to be sent out
  *  failed checksum validation, and the Continue-ATS-on_checksum-Failure flag was
  *  set to 'FALSE'
  */

diff --git a/fsw/src/sc_atsrq.c b/fsw/src/sc_atsrq.c
@@ -179,11 +179,11 @@ void SC_StopAtsCmd(const CFE_SB_Buffer_t *BufPtr)
 /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
 bool SC_BeginAts(uint16 AtsIndex, uint16 TimeOffset)
 {
-    SC_AtsEntryHeader_t *Entry;       /* ATS table entry pointer */
-    int32                EntryIndex;  /* ATS entry location in table */
-    SC_AbsTimeTag_t      ListCmdTime; /* list entry execution time */
-    int32                TimeIndex;   /* the current time buffer index */
-    int32                CmdIndex;    /* ATS command index (cmd num - 1) */
+    SC_AtsEntryHeader_t *Entry;           /* ATS table entry pointer */
+    int32                EntryIndex;      /* ATS entry location in table */
+    SC_AbsTimeTag_t      ListCmdTime = 0; /* list entry execution time */
+    int32                TimeIndex;       /* the current time buffer index */
+    int32                CmdIndex;        /* ATS command index (cmd num - 1) */
     bool                 ReturnCode;
     SC_AbsTimeTag_t      TimeToStartAts; /* the REAL time to start the ATS */
     uint16               CmdsSkipped = 0;