Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration candidate: 2021-03-12 #267

Closed
wants to merge 1 commit into from
Closed

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Mar 12, 2021

Describe the contribution
HOTFIX - for older CMake support

Testing performed
CI

Expected behavior changes
See PRs

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@jphickey

Certain operations in the recent baseline were dependent on a
recent version of CMake.  In particular object libraries cannot
be used in the intended way in the older versions.  This adds
workarounds for those cases.

Tested against CMake versions 3.5.1, 3.10.2, and 3.16.3.
@skliper skliper added this to the 1.6.0 milestone Mar 12, 2021
@skliper skliper added the invalid This doesn't seem right label Mar 12, 2021
@skliper skliper removed this from the 1.6.0 milestone Mar 12, 2021
@skliper
Copy link
Contributor Author

skliper commented Mar 12, 2021

Wrong fork, see #268

@skliper skliper closed this Mar 12, 2021
@jphickey jphickey deleted the ic-20210312 branch April 17, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants