Fix #145, Update RTEMS CMake module #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses various compatibility/usability issues observed during testing - Correctly set/export the CMAKE_EXE_EXPORTS_C_FLAG - Incorporate the system specs directly into the COMPILE_OBJECT templates so these don't need to be specified by the toolchain or CMAKE_C_FLAGS - Similarly include the always-needed linker flags flags for entry point and relocation address into the linker command template
skliper
approved these changes
Apr 2, 2020
|
Looks fine to me but I haven't built for RTEMS in years. Maybe @acudmore could review? |
jphickey
added
the
CCB:Ready
|
CCB 20200408 - APPROVED |
astrogeco
added
CCB - 20200408
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Addresses various compatibility/usability issues observed during testing
so these don't need to be specified by the toolchain or CMAKE_C_FLAGS
and relocation address into the linker command template
Fixes #145
Testing performed
Build for i686-rtems4.11 (in combination with nasa/cFE#573).
Execute CFE and perform basic sanity check (boots, accepts cmd msgs)
Expected behavior changes
RTEMS builds successfully without errors
System(s) tested on
Ubuntu 18.04 LTS 64 bit build host with cross tools for RTEMS 4.11.3/pc686 built according to README.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.