Update grut699-vxworks6 cfe_psp_start.c per white box unit testing results

[skliper]

During white box testing the following issue was identified with the grut699-vxworks6 version of cfe_psp_start.c

• In CFE_PSP_GetRestartType, the input pointer is not checked for NULL prior to dereferencing it.

Issue identified during #14 white box testing, commit: [changeset:ad4e7c5f]

[skliper]

Imported from trac issue 37. Created by dasp on 2015-08-13T19:20:41, last modified: 2019-05-06T11:53:59

[skliper]

Trac comment by sduran on 2015-08-17 15:15:50:

add NULL check

[skliper]

Trac comment by abrown4 on 2015-08-17 16:20:20:

Troublesome...this function doesn't have a convenient type to return to indicate "error". In cfe_es_resetTypes.h we have:
{{{
/*
** Reset types
*/
#define CFE_ES_PROCESSOR_RESET 1 /*Volatile disk, Critical Data Store and User Reserved memory could still be valid */
#define CFE_ES_POWERON_RESET 2 /*All memory has been cleared */
#define CFE_ES_APP_RESTART 3 /*Application only was reset */
}}}

..and the function is:
{{{
/******************************************************************************
** Function: CFE_PSP_GetRestartType()
**
** Purpose:
** Retrieve the CFE PSP reset type and subtype.
**
** Arguments:
** restartSubType [out] Reset Sub Type
**
** Return:
** Reset Type
*/
uint32 CFE_PSP_GetRestartType(uint32 *restartSubType)
{
*restartSubType = ResetSubtype;
return ResetType;
}
}}}

Options:

1. We could change the return type to int32 (across all the PSPs) and return the existing CFE_PSP_INVALID_POINTER error (-2, from cfe_psp.h).
2. We could make a zero=based *ERROR type for this function?
3. We could not alter the return value and simply ignore the NULL argument. (With no signal back to the caller that they've done something "wrong".)

[skliper]

Trac comment by abrown4 on 2015-08-18 12:23:29:

commit: [changeset:1931394] Trac #41 Updated CFE_PSP_GetRestartType() to ignore null pointer. Updated white-box unit test for testing & added "()" for compiler warning.

[skliper]

Trac comment by jhageman on 2019-05-06 11:53:59:

Specific to non-community PSP so closing as invalid. Note changes were merged to techdev-pc-linux-uei, techdev-sp0-vxworks6.9 branches (but not techdev-ut699 for some reason). Not in framework release.