Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the calculated results in CFE_PSP_WatchdogSet #39

Closed
skliper opened this issue Sep 25, 2019 · 4 comments
Closed

Limit the calculated results in CFE_PSP_WatchdogSet #39

skliper opened this issue Sep 25, 2019 · 4 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@skliper
Copy link
Contributor

skliper commented Sep 25, 2019 •
edited
Loading

CFE_PSP_WatchdogSet computes a new value to set the watchdog timer to, but does not limit the results to the specified min and max values (CFE_PSP_WATCHDOG_MIN and CFE_PSP_WATCHDOG_MAX).

The calculation is also not protected from overflowing the possible range, so it is possible to get a much different result than expected.

Issues identified during #14 white box testing commit:[changeset:998ebe4a]
@skliper skliper self-assigned this Sep 25, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Imported from trac issue 35. Created by dasp on 2015-08-13T18:40:00, last modified: 2019-05-06T11:48:33

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by sduran on 2015-08-17 15:25:40:

add limiting code

@skliper skliper added the bug Something isn't working label Sep 25, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019 •
edited
Loading

Trac comment by abrown4 on 2015-08-17 17:29:21:

commit: [changeset:5563878] Trac #39 Added range-limited calaculation to CFE_PS_WatchdogSet().

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by jhageman on 2019-05-06 11:48:33:

Specific to non-community PSP so closing as invalid. Note changes were merged to techdev-pc-linux-uei, techdev-sp0-vxworks6.9 branches (but not techdev-ut699 for some reason). Not in framework release.

@skliper skliper closed this as completed Sep 25, 2019
@skliper skliper removed their assignment Sep 26, 2019
@skliper skliper mentioned this issue Sep 26, 2019
Closed
@skliper skliper added the invalid This doesn't seem right label Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skliper