CFE_PSP_Module_FindByName uses incorrect list limit/stop condition

[jphickey]

Describe the bug
The internal variable CFE_PSP_ModuleCount is used as the limit for searching for a matching name in the PSP module list here:

PSP/fsw/shared/src/cfe_psp_module.c

Line 127 in 15c2ced

while (i < CFE_PSP_ModuleCount)

However, a while back the set of modules was split into two, so now we have separate lists:

CFE_PSP_BASE_MODULE_LIST
GLOBAL_CONFIGDATA.PspModuleList

The CFE_PSP_ModuleCount value reflects the total number of entries (sum) of both lists.
But the CFE_PSP_Module_FindByName function is only searching the second list (GLOBAL_CONFIGDATA.PspModuleList). This means that if there is no matching entry, it might read beyond the end of the list.

To Reproduce
Call CFE_PSP_Module_FindByName on a module name that does not actually exist in the system. The loop will segfault when it gets to the NULL entry that normally terminates the GLOBAL_CONFIGDATA.PspModuleList.

Expected behavior
The search should cover CFE_PSP_BASE_MODULE_LIST and GLOBAL_CONFIGDATA.PspModuleList like the init function does

Code snips
Init function uses a helper function that does each list at:

PSP/fsw/shared/src/cfe_psp_module.c

Lines 80 to 87 in 15c2ced

	void CFE_PSP_ModuleInit(void)
	{
	/* First initialize the fixed set of modules for this PSP */
	CFE_PSP_ModuleInitList(CFE_PSP_BASE_MODULE_LIST);
	/* Then initialize any user-selected extension modules */
	CFE_PSP_ModuleInitList(GLOBAL_CONFIGDATA.PspModuleList);
	}

Search function should mirror this.

System observed on:
Ubuntu 22.04

Reporter Info
Joseph Hickey, Vantage Systems, Inc. on behalf of Alan Cudmore (GSFC)

[jphickey]

Worth noting that this code in this file does NOT seem to have a coverage test for it ... this limit mismatch issue may have been caught by such a test.