Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commented out code #350

Closed
jphickey opened this issue Jul 8, 2022 · 0 comments · Fixed by #351 or #352
Closed

Remove commented out code #350

jphickey opened this issue Jul 8, 2022 · 0 comments · Fixed by #351 or #352
Assignees
@jphickey
Milestone
Draco

Comments

@jphickey
Copy link
Contributor

jphickey commented Jul 8, 2022

Is your feature request related to a problem? Please describe.
While developing other software I noticed some "jphfix" comment tags remaining. These should have been removed before commit but were missed (mistake).

PSP/unit-test-coverage/shared/src/coveragetest-cfe-psp-exceptionstorage.c

Lines 45 to 50 in a8ae3bc

#ifdef jphfix
#include "PCS_stdlib.h"
#include "PCS_rebootLib.h"
#include "PCS_cacheLib.h"
#include "PCS_cfe_configdata.h"
#endif

Describe the solution you'd like
Remove commented out code

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jul 8, 2022
jphickey added a commit to jphickey/PSP that referenced this issue Jul 8, 2022
@jphickey
Fix nasa#350, remove commented out code
60f4c06 
Clean up code block that was ifdef'd out
@jphickey jphickey mentioned this issue Jul 8, 2022
Merged
2 tasks
dzbaker added a commit that referenced this issue Jul 13, 2022
@dzbaker
Merge pull request #351 from jphickey/fix-350-remove-jphfix
8675160 
Fix #350, remove commented out code
@dzbaker dzbaker mentioned this issue Jul 14, 2022
Merged
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
None yet
Projects
None yet
Milestone
Draco
2 participants
@jphickey @dmknutsen