Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update static analysis workflow strict directory list for nasa/cFS#453 #333

Closed
skliper opened this issue Apr 8, 2022 · 1 comment · Fixed by #334
Closed

Update static analysis workflow strict directory list for nasa/cFS#453 #333

skliper opened this issue Apr 8, 2022 · 1 comment · Fixed by #334
Labels
continuous-integration
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Apr 8, 2022

Is your feature request related to a problem? Please describe.
See #453, really PSP was the only repo that worked right in the presence of the leading . applied within the shared workflow since it's a single directory.

Describe the solution you'd like
Provide directory relative to local repo such that a list will also work

Describe alternatives you've considered
None

Additional context
nasa/cFS#453

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the Draco milestone Apr 8, 2022
This was referenced Apr 8, 2022
Closed
Merged
@skliper skliper mentioned this issue Apr 8, 2022
Merged
astrogeco added a commit that referenced this issue Apr 18, 2022
@astrogeco
Merge pull request #334 from skliper/fix333-static_analysis
a2742ef 
Fix #333, Relative strict-dir-list for static analysis workflow
astrogeco added a commit that referenced this issue Apr 18, 2022
@astrogeco
Merge pull request #334 from skliper/fix333-static_analysis
01eec8e 
Fix #333, Relative strict-dir-list for static analysis workflow

- HOTFIX #334, remove `./` prefix to fsw from strict-dir-list input
astrogeco added a commit that referenced this issue Apr 18, 2022
@astrogeco
Merge pull request #334 from skliper/fix333-static_analysis
55a575e 
Fix #333, Relative strict-dir-list for static analysis workflow

- HOTFIX #334, remove `/` prefix to fsw from strict-dir-list input
@astrogeco astrogeco reopened this Apr 19, 2022
@skliper
Copy link
Contributor Author

skliper commented Apr 19, 2022

Reopen was in error (not sure how it was triggered). Closing based on merge of #334.

@skliper skliper closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous-integration
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #333, Relative strict-dir-list for static analysis workflow skliper/PSP
2 participants
@skliper @astrogeco