Remove "GLOBAL_PSP_CONFIGDATA" object #280
Comments
This was referenced Mar 31, 2021
jphickey
added a commit
to jphickey/PSP
that referenced
this issue
Mar 31, 2021
This global config structure is not really necessary. The original intent was to allow dependents (e.g. CFE) to get vars at runtime but keep them stored within PSP. However for all those cases where CFE needs PSP info, an API function is defined to get the info. There should not be any need to read this variable directly.
astrogeco
added a commit
that referenced
this issue
Apr 2, 2021
Fix #280, remove psp configdata global object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
This global/constant structure object was originally added to facilitate modular linking, but isn't really necessary anymore, and was never really used. As it stands today, only the PSP has it, which makes it a bit of an anomaly in the system context.
Describe the solution you'd like
Clean it up, remove this extra global object.
Additional context
In contrast the similar object
GLOBAL_CFE_CONFIGDATAobject is used, as it facilitates getting PSP access to constants defined in CFE at link time, without PSP having to directly#includethe header that defines it at compile time (as this would create a backwards dependency).The
GLOBAL_PSP_CONFIGDATAobject is the same idea but was for PSP constants, however there isn't the same dependency structure here, so it was never really needed. Only the version info was ever used externally by CFE, and now that is replaced by an API call to get the info, (recent PRs #257 and nasa/cFE#1206) so there is no need for this global at all anymore.Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: