Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PSP to use OS time conversion/access methods #227

Closed
jphickey opened this issue Dec 31, 2020 · 0 comments · Fixed by #231 or #240
Closed

Update PSP to use OS time conversion/access methods #227

jphickey opened this issue Dec 31, 2020 · 0 comments · Fixed by #231 or #240
Assignees
@jphickey
Labels
enhancement New feature or request
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
PSP is directly accessing specific fields within OS_time_t which will break when the struct definition changes.

Describe the solution you'd like
Instead of directly accessing the seconds and microsecs fields within OS_time_t, use the accessor functions to convert/extract the relevant info from the value instead.

Additional context
see nasa/osal#429

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey mentioned this issue Dec 31, 2020
Merged
@jphickey jphickey self-assigned this Dec 31, 2020
@jphickey jphickey added the enhancement New feature or request label Dec 31, 2020
@skliper skliper added this to the 1.6.0 milestone Jan 4, 2021
jphickey added a commit to jphickey/PSP that referenced this issue Jan 4, 2021
@jphickey
Fix nasa#227, Use OSAL time conversion/access methods
30bc10f 
Instead of accessing OS_time_t values directly, use the
OSAL-provided conversion and access methods.  This provides
independence/abstraction from the specific OS_time_t
definition and allows OSAL to transition to a 64 bit value.
@jphickey jphickey mentioned this issue Jan 4, 2021
Merged
astrogeco added a commit that referenced this issue Jan 13, 2021
@astrogeco
Merge pull request #231 from jphickey/fix-227-use-ostime-conversions
b3dcd45 
Fix #227, Use OSAL time conversion/access methods
@astrogeco astrogeco mentioned this issue Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper