-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced error handling and design of parse_data #30
Enhanced error handling and design of parse_data #30
Conversation
FileNotFoundError when config file path results in 0 read files Data influx now denoted as required and optional in comments required data will stop execution with error required data was updated with error handling optional data does not stop execution optional data reatained its original behaviors: booleans are optional, but become None not False when missing benchmark data sets until fail then passes in a "don't care" fashion KeyError catch for required data now extends original key error includes config_filepath includes key value that failed Updated and added approprate unit tests needed return values with length for config.read call added error handling tests
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 1164 1169 +5
Branches 155 156 +1
=========================================
+ Hits 1164 1169 +5
|
Tested by altering config file used by driver.py. Missing output: Missing required key: The above exception was the direct cause of the following exception: Traceback (most recent call last): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the new error message on my machine, and unit test coverage 100%. Code looks good. Thanks!
…parser_util-py-to-100-percent' into 'main' Updates for testing parser_util.py Closes nasa#30 See merge request cFS_lab/raisr_nos3/raisr-2.0!18
FileNotFoundError when config file path results in 0 read files
Data influx now denoted as required and optional in comments
KeyError catch for required data now extends original key error
Updated and added approprate unit tests