Fix #89, correct format spec strings and data types #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } /* end MM_WriteFileHeaders if */ | ||
|
|
||
| /* Close dump file */ | ||
| if ((OS_Status = OS_close(FileHandle)) != OS_SUCCESS) |
Check warning
Code scanning / CodeQL
Side effect in a Boolean expression Warning
Resolves mismatches between format strings and the data types
Resolves whitespace errors, committed separately as MM had accumulated a fair number of other mismatches.
jphickey
force-pushed
the
fix-89-formatspec
branch
from
f13ab15
to
e2399b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Resolves mismatches between format strings and the data types
Fixes #89
Testing performed
Build and run tests
Expected behavior changes
Builds successfully
System(s) tested on
RTEMS 4.11
Additional context
Includes a pass through clang-format, committed separately, as MM had a fair number of whitespace issues.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.