Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #75, Use size_t for size variables/parameters + zero-out the gloabl data struct #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #75, Use size_t for size variables/parameters + zero-out the gloabl data struct #76

wants to merge 1 commit into from

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

  • Fixes Size variables/parameters could be updated to use the size_t type #75
    • Converts suitable variables + function parameters that represent size to the size_t type
    • Zero's out the global data struct at the beginning of initialization
    • A couple of minor fixes are added here including typos and replacing some function name text to use __func__ (to avoid potential future technical debt)

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

System(s) tested on
Debian GNU/Linux 12 (bookworm)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 18, 2024
View reviewed changes
fsw/src/md_utils.c
@@ -142,7 +142,7 @@

/******************************************************************************/

bool MD_Verify32Aligned(cpuaddr Address, uint32 Size)
bool MD_Verify32Aligned(cpuaddr Address, size_t Size)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/md_utils.c
@@ -164,7 +164,7 @@

/******************************************************************************/

bool MD_Verify16Aligned(cpuaddr Address, uint32 Size)
bool MD_Verify16Aligned(cpuaddr Address, size_t Size)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Size variables/parameters could be updated to use the size_t type
1 participant
@thnkslprpt