Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #36, Apply consistent Event ID names to common events #37

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 21, 2022

Checklist

Describe the contribution

Testing performed
Only GitHub CI actions.

Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker self-assigned this Oct 27, 2022
@dzbaker
Copy link
Contributor

dzbaker commented Oct 31, 2022

@thnkslprpt Are you able to resolve the workflow failures?

@thnkslprpt
Copy link
Contributor Author

thnkslprpt commented Oct 31, 2022

@thnkslprpt Are you able to resolve the workflow failures?

I'm not sure...
I think those failures have come up on every run of the actions recently, not matter what is changed:
image
image

@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
@thnkslprpt thnkslprpt force-pushed the fix-36-apply-consistent-event-id-names branch from 03f0486 to 987d70f Compare March 12, 2023 03:42
@thnkslprpt thnkslprpt force-pushed the fix-36-apply-consistent-event-id-names branch from 987d70f to 11b5c08 Compare April 2, 2023 00:00
@thnkslprpt thnkslprpt force-pushed the fix-36-apply-consistent-event-id-names branch from 11b5c08 to 9c55b90 Compare May 5, 2023 03:02
@thnkslprpt thnkslprpt force-pushed the fix-36-apply-consistent-event-id-names branch 2 times, most recently from 4f5fc3d to 51402b6 Compare November 1, 2023 17:38
@thnkslprpt thnkslprpt force-pushed the fix-36-apply-consistent-event-id-names branch from 51402b6 to 8c361b3 Compare January 25, 2024 22:47
@dzbaker dzbaker merged commit 40aeed1 into nasa:main Jul 15, 2024
17 checks passed
@thnkslprpt thnkslprpt deleted the fix-36-apply-consistent-event-id-names branch July 16, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Event ID naming
2 participants