Uncovered lines/branches

[havencarlson]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug

• Fix Revisit coverage, update to 100% code/branch or write issues where unreachable #7: found instances of branches that can never be reached by unit tests.

To Reproduce
Functions with statements that can never be reached:

md_app.c: MD_ExecRequest
can't hit default case since command codes are already verified by MD_SearchCmdHndlrTbl

MD/fsw/src/md_app.c

Lines 666 to 671 in 853c1e0

	default:
	/* unknown function code specified - send error event message */
	CFE_EVS_SendEvent(MD_CC_NOT_IN_LOOP_ERR_EID, CFE_EVS_EventType_ERROR,
	"Command Code %d not found in command processing loop", CommandCode);
	MD_AppData.ErrCounter++;
	break;

md_app.c: MD_SearchCmdHndlrTbl
can't reach this else statement because the message type can't be anything other than MD_CMD_MSGTYPE or MD_TERM_MSGTYPE

MD/fsw/src/md_app.c

Lines 761 to 766 in 853c1e0

	else
	/* Message is not a command message with specific command code */
	{
	/* Matching Message ID is all that is required */
	FoundMatch = true;
	}

md_dwell_tbl.c: MD_TableValidationFunc

MD/fsw/src/md_dwell_tbl.c

Lines 145 to 149 in 853c1e0

	else
	{
	/* Should not get here, MD_ValidTableEntry only returns the above values */
	Status = -1;
	}

Expected behavior
100% coverage

Code snips
See above

System observed on:
CI

Additional context
None

Reporter Info
Haven Carlson, NASA

[skliper]

Note the first two would go away if command handling gets updated as part of this enhancement nasa/cFE#2038, or could separate the functions (different c file) to stub and exercise error cases, or could include the HK request MID in the table (refactor to match TBL implementation). Either way these are low risk since it's just defensive programming. The else condition in the dwell table could just be replaced with a comment that there is no action for a case that isn't matched, also low risk.