Merge pull request #74 from chillfig/SA_jsc2_1

Fix #71, Adds JSC 2.1 Static Analysis comments
nasa · Jun 27, 2024 · aac8085 · aac8085
2 parents 72242ea + 5a5e794
commit aac8085
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/fsw/src/md_dwell_tbl.c b/fsw/src/md_dwell_tbl.c
@@ -392,6 +392,7 @@ CFE_Status_t MD_UpdateTableDwellEntry(uint16 TableIndex, uint16 EntryIndex, uint
         strncpy(EntryPtr->DwellAddress.SymName, NewDwellAddress.SymName, OS_MAX_SYM_LEN - 1);
 
         /* Ensure string is null terminated. */
+        /* SAD: SymName’s last element is accessed on this line by reference to its max size, greatly reducing an off by one risk */
         EntryPtr->DwellAddress.SymName[OS_MAX_SYM_LEN - 1] = '\0';
 
         /* Notify Table Services that buffer was modified */